Add Global Cluster support #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trenton Lawrence <pitime2@outlook.com>
ActuallyTrent
force-pushed
the
task/mothership/add-global-cluster
branch
from
172f62c
to
9553ddd
Compare
muvaf
approved these changes
May 24, 2021
apis/rds/v1alpha1/custom_types.go
Outdated
| // SourceDBClusterIdentifier. | ||
| // +immutable | ||
| // +optional | ||
| SourceDBClusterIDRef *xpv1.Reference `json:"sourceDBClusterIDRef,omitempty"` |
There was a problem hiding this comment.
Suggested change
| SourceDBClusterIDRef *xpv1.Reference `json:"sourceDBClusterIDRef,omitempty"` | |
| SourceDBClusterIdentifierRef *xpv1.Reference `json:"sourceDBClusterIdentifierRef,omitempty"` |
We use the exact name of the field as prefix for consistencty.
apis/rds/v1alpha1/custom_types.go
Outdated
| // set SourceDBClusterIdentifier. | ||
| // +immutable | ||
| // +optional | ||
| SourceDBClusterIDSelector *xpv1.Selector `json:"sourceDBClusterIDSelector,omitempty"` |
There was a problem hiding this comment.
Suggested change
| SourceDBClusterIDSelector *xpv1.Selector `json:"sourceDBClusterIDSelector,omitempty"` | |
| SourceDBClusterIdentifierSelector *xpv1.Reference `json:"sourceDBClusterIdentifierSelector,omitempty"` |
We use the exact name of the field as prefix for consistencty.
| clusterIdentifier := aws.String(meta.GetExternalName(cr)) | ||
| resp := &svcsdk.DescribeGlobalClustersOutput{} | ||
| for _, dbCluster := range obj.GlobalClusters { | ||
| if aws.StringValue(dbCluster.GlobalClusterIdentifier) == aws.StringValue(clusterIdentifier) { |
There was a problem hiding this comment.
Suggested change
| if aws.StringValue(dbCluster.GlobalClusterIdentifier) == aws.StringValue(clusterIdentifier) { | |
| if aws.StringValue(dbCluster.GlobalClusterIdentifier) == meta.GetExternalName(cr) { |
…ency Signed-off-by: Trenton Lawrence <pitime2@outlook.com>
ActuallyTrent
force-pushed
the
task/mothership/add-global-cluster
branch
from
714204d
to
fec6ea2
Compare
|
Thanks @PocketMobsters ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds support for Global Aurora Clusters
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
sourceDBClusterIDRefand verified it created a GlobalCluster with the sourceDBCluster attached properly.