servicediscovery: refactoring to reduce code duplication #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blut you might want to take a look at this PR to see if I missed something. I believe only d038e7f is a functional change where I made it check the operation only if the external-name is not set, which happens only if the creation operation hasn't been triggered. The rest of the comments are mainly about reusing the |
|
@krishchow can you take a look at this? |
|
Sounds good! Let me give this a review :) |
krishchow
approved these changes
Jun 10, 2021
…e small changes for resiliency of capturing external-name Signed-off-by: Muvaffak Onus <me@muvaf.com>
Signed-off-by: Muvaffak Onus <me@muvaf.com>
…space resources Signed-off-by: Muvaffak Onus <me@muvaf.com>
…etOperation calls Signed-off-by: Muvaffak Onus <me@muvaf.com>
tektondeploy
pushed a commit
to gtn3010/provider-aws
that referenced
this pull request
Mar 12, 2024
aws: uptest non-inherited ones
tektondeploy
pushed a commit
to gtn3010/provider-aws
that referenced
this pull request
Mar 12, 2024
Bump build submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I merged #627 (review) to get the resource in, this PR makes little functional change but allows reuse of common hooks between all three
HTTPNamespace,PrivateDNSNamespaceandPublicDNSNamespaceresources.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually.