Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #735 acm - fixed synced false when using private ca #746

Merged
merged 1 commit into from
Jun 26, 2021

Conversation

haarchri
Copy link
Member

Signed-off-by: Christopher Haar chhaar30@googlemail.com

Description of your changes

Fixes #735

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

NAME                                                DOMAINNAME                     STATUS   READY   SYNCED   AGE
certificate.acm.aws.crossplane.io/poc-certificate   *.mesh-pca.svc.cluster.local   ISSUED   True    True     3m19s
 kubectl describe certificate.acm.aws.crossplane.io/poc-certificate
Name:         poc-certificate
Namespace:    
Labels:       <none>
Annotations:  crossplane.io/external-name: arn:aws:acm:eu-central-1:255932642927:certificate/19b93893-59e9-4fd5-bf11-6fbfc8d34625
API Version:  acm.aws.crossplane.io/v1alpha1
Kind:         Certificate
Metadata:
  Creation Timestamp:  2021-06-26T20:18:13Z
  Finalizers:
    finalizer.managedresource.crossplane.io
  Generation:        2
  Resource Version:  933146
  Self Link:         /apis/acm.aws.crossplane.io/v1alpha1/certificates/poc-certificate
  UID:               fe16cbff-707b-481f-9cad-85de7e01eab3
Spec:
  Deletion Policy:  Delete
  For Provider:
    Certificate Authority ARN:                    arn:aws:acm-pca:eu-central-1:255932642927:certificate-authority/e6a6ac34-056a-49b3-802c-3b446580d9a4
    Certificate Transparency Logging Preference:  DISABLED
    Domain Name:                                  *.mesh-pca.svc.cluster.local
    Domain Validation Options:
      Domain Name:        *.mesh-pca.svc.cluster.local
      Validation Domain:  *.mesh-pca.svc.cluster.local
    Region:               eu-central-1
    Subject Alternative Names:
      *.mesh-pca.svc.cluster.local
    Tags:
      Key:              Name
      Value:            example
    Validation Method:  EMAIL
  Provider Config Ref:
    Name:  default
Status:
  At Provider:
    Certificate ARN:      arn:aws:acm:eu-central-1:255932642927:certificate/19b93893-59e9-4fd5-bf11-6fbfc8d34625
    Renewal Eligibility:  INELIGIBLE
    Status:               ISSUED
    Type:                 PRIVATE
  Conditions:
    Last Transition Time:  2021-06-26T20:18:14Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
    Last Transition Time:  2021-06-26T20:18:18Z
    Reason:                Available
    Status:                True
    Type:                  Ready

image

Signed-off-by: Christopher Haar <chhaar30@googlemail.com>
Copy link
Member

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work @haarchri :)

@hasheddan hasheddan merged commit 0d44ab4 into crossplane-contrib:master Jun 26, 2021
@haarchri haarchri mentioned this pull request Oct 21, 2021
6 tasks
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
…-input

Remove version input from `publish-service-artifacts.yml`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certificate not synced when using Private CA
2 participants