version: bump ec2/vpccidrblock package to manualv1alpha1

[haarchri]

Signed-off-by: Christopher Haar chhaar30@googlemail.com

bump package version for ec2/vpccidrblock to manualv1alpha1 to use v1alpha1 for code-generator stuff
in #689 we see the problem between custom and code-generator stuff in one - for example: of zz_types.go
think it is better not mix-up the both approaches

what did you guys think ?

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

➜  provider-aws git:(ec2-vpccidrblock) ✗ kubectl apply -f examples/ec2/vpccidrblock.yaml
vpccidrblock.ec2.aws.crossplane.io/sample-vpc-cidr-block created

➜  provider-aws git:(ec2-vpccidrblock) ✗ kubectl delete -f examples/ec2/vpccidrblock.yaml
vpccidrblock.ec2.aws.crossplane.io "sample-vpc-cidr-block" deleted

[AaronME]

I see what you are saying. And I agree that it would be nice to have a distinction between the generated and non-generated types. Could using alpha2 for non-generated create confusion? Someone could infer that alpha2 indicates a more recent, and preferred, approach. When really we prefer people to follow practices in alpha1.

[haarchri]

so what is your prefered way ? at the moment we need to modify in ec2 zz_ files if we want integrate more services with code-generator

[hasheddan]

@haarchri we don't need to actually change the API version, we can just change the package name so that the generated code lives in a different package. Users of this API should have the same experience as they do currently 👍🏻

[haarchri]

@hasheddan can you provide a example ? At the moment the code-generator will add in ec2 v1alpha1

[hasheddan]

@haarchri left some guiding comments below, let me know if you want to sync up about them if they aren't illustrating my suggestions well 👍🏻

[haarchri]

@hasheddan i changed the packag to manualv1alpha1 and the generated crds using v1alpha1 - think this was this what you mentioned ;)

tested via apply and delete

for delete i added a fix that the ressource is removed when vpccidrblock is in status VpcCidrBlockStateCodeDisassociated
you can have a look

[hasheddan]

Thank you @haarchri !