Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements transfer server and user #754

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Jun 30, 2021

Signed-off-by: Christopher Haar chhaar30@googlemail.com

Description of your changes

implements transfer

  • server
  • user

Fixes #722 #748

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

kubectl get managed
NAME                                        READY   SYNCED   EXTERNAL-NAME
server.transfer.aws.crossplane.io/example   True    True     s-c1ed444984374e53a

NAME                                      READY   SYNCED   EXTERNAL-NAME
user.transfer.aws.crossplane.io/example   True    True     example
kubectl describe server.transfer.aws.crossplane.io/example
Name:         example
Namespace:    
Labels:       <none>
Annotations:  crossplane.io/external-name: s-c1ed444984374e53a
API Version:  transfer.aws.crossplane.io/v1alpha1
Kind:         Server
Metadata:
  Creation Timestamp:  2021-07-05T20:05:18Z
  Finalizers:
    finalizer.managedresource.crossplane.io
  Generation:        2
  Resource Version:  1269563
  Self Link:         /apis/transfer.aws.crossplane.io/v1alpha1/servers/example
  UID:               95dd807d-c4da-499c-ba60-756fa23130c3
Spec:
  Deletion Policy:  Delete
  For Provider:
    Domain:  S3
    Endpoint Details:
      Security Group ID Refs:
        Name:  example
      Security Group I Ds:
        sg-0858486fe394890bf
      Subnet ID Refs:
        Name:  sample-subnet1
      Subnet I Ds:
        subnet-f2ccb898
      Vpc ID:  vpc-aab73bc0
      Vpc ID Ref:
        Name:                sample-vpc
    Endpoint Type:           VPC
    Identity Provider Type:  SERVICE_MANAGED
    Protocols:
      SFTP
    Region:                eu-central-1
    Security Policy Name:  TransferSecurityPolicy-2020-06
    Tags:
      Key:    myKey
      Value:  myValue
  Provider Config Ref:
    Name:  default
  Write Connection Secret To Ref:
    Name:       example-conn
    Namespace:  crossplane-system
Status:
  At Provider:
    Server ID:  s-c1ed444984374e53a
  Conditions:
    Last Transition Time:  2021-07-05T20:05:20Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
    Last Transition Time:  2021-07-05T20:06:21Z
    Reason:                Available
    Status:                True
    Type:                  Ready
Events:
  Type    Reason                   Age   From                                       Message
  ----    ------                   ----  ----                                       -------
  Normal  CreatedExternalResource  69s   managed/server.transfer.aws.crossplane.io  Successfully requested creation of external resource
kubectl describe user.transfer.aws.crossplane.io/example
Name:         example
Namespace:    
Labels:       <none>
Annotations:  crossplane.io/external-name: example
API Version:  transfer.aws.crossplane.io/v1alpha1
Kind:         User
Metadata:
  Creation Timestamp:  2021-07-05T20:06:38Z
  Finalizers:
    finalizer.managedresource.crossplane.io
  Generation:        2
  Resource Version:  1269634
  Self Link:         /apis/transfer.aws.crossplane.io/v1alpha1/users/example
  UID:               f9fc8845-dfbe-48fa-832c-82c51b3aa164
Spec:
  Deletion Policy:  Delete
  For Provider:
    Home Directory:       /aws-glue-crossplane/example
    Home Directory Type:  PATH
    Region:               eu-central-1
    Role:                 arn:aws:iam::1234567891012:role/aws-glue
    Role Ref:
      Name:     aws-glue
    Server ID:  s-c1ed444984374e53a
    Server ID Ref:
      Name:               example
    Ssh Public Key Body:  ssh-rsa <ssh-key>
    Tags:
      Key:    myKey
      Value:  myValue
  Provider Config Ref:
    Name:  default
Status:
  At Provider:
    Server ID:  s-c1ed444984374e53a
  Conditions:
    Last Transition Time:  2021-07-05T20:06:39Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
    Last Transition Time:  2021-07-05T20:06:39Z
    Reason:                Available
    Status:                True
    Type:                  Ready
Events:
  Type    Reason                   Age    From                                     Message
  ----    ------                   ----   ----                                     -------
  Normal  CreatedExternalResource  2m14s  managed/user.transfer.aws.crossplane.io  Successfully requested creation of external resource

@haarchri haarchri changed the title WIP: Implements transfer server and user Implements transfer server and user Jul 5, 2021
@AaronME AaronME added the size/M label Aug 12, 2021
@AaronME AaronME self-requested a review August 26, 2021 17:10
@AaronME AaronME self-assigned this Aug 27, 2021
Copy link
Collaborator

@AaronME AaronME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haarchri - Nice work, thank you for the PR!

I've asked for one update to improve conformance compatibility. This works well in a local test.

examples/transfer/server.yaml Outdated Show resolved Hide resolved
@haarchri haarchri force-pushed the transfer branch 2 times, most recently from adb6b82 to 3575a4a Compare August 28, 2021 08:26
@haarchri
Copy link
Member Author

haarchri commented Aug 28, 2021

@AaronME changed the example, squashed commits & rebase master
thanks for review ;)

Signed-off-by: Christopher Haar <chhaar30@googlemail.com>
@tilegg
Copy link

tilegg commented Sep 27, 2021

What is the status of this feature?
We were hoping to get this as part of the upcoming 0.20 release. Is there anything blocking or can we expect it as part of the release?

@AaronME AaronME self-requested a review September 30, 2021 22:36
Copy link
Collaborator

@AaronME AaronME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haarchri This looks great! Thank you for the contribution.

I was able to create and delete the examples with this code.

@AaronME AaronME merged commit 9bf57cd into crossplane-contrib:master Oct 1, 2021
@haarchri haarchri mentioned this pull request Oct 21, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement AWS Transfer
3 participants