Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database.rdsinstance: Add more ready states (can receive requests) #761

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

chlunde
Copy link
Collaborator

@chlunde chlunde commented Jul 6, 2021

Description of your changes

Add some more "known good" states in which an RDS instance can receive
requests:

  • Modifying
  • Backing Up
  • Configuring Enhanced Monitoring

Fixes #760

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

In AWS

Add some more "known good" states in which an RDS instance can receive
requests:

* Modifying
* Backing Up
* Configuring Enhanced Monitoring

Fixes crossplane-contrib#760

Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
Copy link
Collaborator

@AaronME AaronME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! AWS Console doesn't even show the enhanced-monitoring phase.

@AaronME AaronME added the size/S label Aug 12, 2021
@AaronME AaronME merged commit 99992ae into crossplane-contrib:master Aug 13, 2021
@chlunde chlunde mentioned this pull request Aug 20, 2021
6 tasks
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
…caling

Add appautoscaling api group resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RDSInstance not "ready" during backup and modifications
2 participants