Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements EC2 Volume #771

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Conversation

haarchri
Copy link
Member

Description of your changes

add ec2/volume

Fixes #739

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

➜  provider-aws git:(ebs-volume) ✗ kubectl apply -f examples/ec2/volume.yaml            
volume.ec2.aws.crossplane.io/example created
➜  provider-aws git:(ebs-volume) ✗ kubectl describe volume.ec2.aws.crossplane.io/example
Name:         example
Namespace:    
Labels:       <none>
Annotations:  crossplane.io/external-name: vol-0cc9d21d80a60ec2a
API Version:  ec2.aws.crossplane.io/v1alpha1
Kind:         Volume
Metadata:
  Creation Timestamp:  2021-07-19T10:13:54Z
  Finalizers:
    finalizer.managedresource.crossplane.io
  Generation:        2
  Resource Version:  1563377
  Self Link:         /apis/ec2.aws.crossplane.io/v1alpha1/volumes/example
  UID:               61172836-e203-49d7-a755-6b2677f5d7d0
Spec:
  Deletion Policy:  Delete
  For Provider:
    Availability Zone:  eu-central-1a
    Encrypted:          true
    Kms Key ID:         ea87e120-8417-4ade-8499-9e093d5664d7
    Kms Key ID Ref:
      Name:       dev-key
    Region:       eu-central-1
    Size:         1
    Volume Type:  gp3
  Provider Config Ref:
    Name:  default
Status:
  At Provider:
    Create Time:  2021-07-19T10:13:55Z
    State:        available
    Volume ID:    vol-0cc9d21d80a60ec2a
  Conditions:
    Last Transition Time:  2021-07-19T10:13:55Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
    Last Transition Time:  2021-07-19T10:14:56Z
    Reason:                Available
    Status:                True
    Type:                  Ready
Events:
  Type    Reason                   Age   From                                  Message
  ----    ------                   ----  ----                                  -------
  Normal  CreatedExternalResource  2m4s  managed/volume.ec2.aws.crossplane.io  Successfully requested creation of external resource
➜  provider-aws git:(ebs-volume) ✗ kubectl delete -f examples/ec2/volume.yaml           
volume.ec2.aws.crossplane.io "example" deleted

@haarchri haarchri changed the title Implements EC2 Volume (EBS) Implements EC2 Volume Jul 19, 2021
@AaronME AaronME added the size/L label Aug 12, 2021
@AaronME
Copy link
Collaborator

AaronME commented Sep 24, 2021

@haarchri Please rebase this and we can run through testing.

Thank you!

@AaronME AaronME self-assigned this Sep 24, 2021
@haarchri haarchri force-pushed the ebs-volume branch 2 times, most recently from b0c6142 to 36b3864 Compare September 24, 2021 18:28
@haarchri haarchri mentioned this pull request Oct 21, 2021
6 tasks
@haarchri
Copy link
Member Author

still blocked by #920

@haarchri haarchri force-pushed the ebs-volume branch 3 times, most recently from 94819c4 to 84f880f Compare December 10, 2021 08:15
@haarchri haarchri closed this Dec 10, 2021
@haarchri haarchri reopened this Dec 10, 2021
@haarchri
Copy link
Member Author

@AaronME thanks for bump codeGenerator with #920 i rebased and tested this PR again

 kubectl get volume
NAME      READY   SYNCED   EXTERNAL-NAME
example   True    True     vol-0b94a54f369e2d42e

Copy link
Collaborator

@AaronME AaronME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @haarchri !

@haarchri haarchri force-pushed the ebs-volume branch 2 times, most recently from db6645c to ef629b3 Compare December 14, 2021 08:33
Signed-off-by: haarchri <chhaar30@googlemail.com>
@haarchri haarchri merged commit 30a832f into crossplane-contrib:master Dec 14, 2021
@haarchri haarchri deleted the ebs-volume branch December 14, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement EBS volumes
3 participants