Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements kms(cmk) alias #779

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Conversation

haarchri
Copy link
Member

Description of your changes

Implements kms(cmk) alias

Fixes #778

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

➜  provider-aws git:(kms-alias) ✗ kubectl apply -f examples/kms/alias.yaml
alias.kms.aws.crossplane.io/dev-key created
➜  provider-aws git:(kms-alias) ✗ kubectl get alias
NAME      READY   SYNCED   EXTERNAL-NAME
dev-key   True    True     alias/dev-key
➜  provider-aws git:(kms-alias) ✗ kubectl describe alias dev-key
Name:         dev-key
Namespace:    
Labels:       <none>
Annotations:  crossplane.io/external-name: alias/dev-key
API Version:  kms.aws.crossplane.io/v1alpha1
Kind:         Alias
Metadata:
  Creation Timestamp:  2021-07-26T21:49:35Z
  Finalizers:
    finalizer.managedresource.crossplane.io
  Generation:        2
  Resource Version:  1975464
  Self Link:         /apis/kms.aws.crossplane.io/v1alpha1/aliases/dev-key
  UID:               36159cba-4325-48f7-a3d8-964be025676c
Spec:
  Deletion Policy:  Delete
  For Provider:
    Alias Name:     alias/dev-key
    Region:         eu-central-1
    Target Key ID:  ea87e120-8417-4ade-8499-9e093d5664d7
    Target Key ID Ref:
      Name:  dev-key
  Provider Config Ref:
    Name:  default
Status:
  At Provider:
  Conditions:
    Last Transition Time:  2021-07-26T21:49:35Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
    Last Transition Time:  2021-07-26T21:49:35Z
    Reason:                Available
    Status:                True
    Type:                  Ready
Events:
  Type    Reason                   Age   From                                 Message
  ----    ------                   ----  ----                                 -------
  Normal  CreatedExternalResource  35s   managed/alias.kms.aws.crossplane.io  Successfully requested creation of external resource
➜  provider-aws git:(kms-alias) ✗ kubectl delete -f examples/kms/alias.yaml
alias.kms.aws.crossplane.io "dev-key" deleted

Copy link
Collaborator

@AaronME AaronME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks, @haarchri !

@AaronME
Copy link
Collaborator

AaronME commented Oct 1, 2021

Closing and re-opening to trigger tests.

@AaronME AaronME closed this Oct 1, 2021
@AaronME AaronME reopened this Oct 1, 2021
Signed-off-by: Christopher Haar <chhaar30@googlemail.com>
@haarchri haarchri mentioned this pull request Oct 21, 2021
6 tasks
@muvaf muvaf merged commit ab72309 into crossplane-contrib:master Nov 16, 2021
@muvaf muvaf mentioned this pull request Nov 17, 2021
2 tasks
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
…re-time

upjet: update upjet to the latest in all providers
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
Fix issue 726: Missing selector in Broker resource for selecting security groups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KMS Key Alias
3 participants