Give all EC2 managed resources a 3 minute creation grace period #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlunde
approved these changes
Sep 8, 2021
chlunde
reviewed
Sep 8, 2021
go.mod
Outdated
| k8s.io/api v0.21.3 | ||
| k8s.io/apimachinery v0.21.3 | ||
| k8s.io/client-go v0.21.3 | ||
| sigs.k8s.io/controller-runtime v0.9.6 |
There was a problem hiding this comment.
I suspect this will require rebasing lots of the other "new resource" PRs in this repo, and possibly the two large bumps of AWS SDK PRs? If so, I'm a bit worried about contributor "churn" due to this. The "solution" is probably to reduce the number of WIP PRs, but it's also a question of what goes in first of these changes (which ones are mechanical and easier to rebase).
There was a problem hiding this comment.
Fair point. We already released patches with this fix, so I'm happy to hold off and take the rebase hit after we get the backlog down a bit.
|
@negz Looks like this is ready to merge? |
This commit fixes crossplane-contrib#802 Signed-off-by: Nic Cope <negz@rk0n.org>
This means we'll wait three minutes from the time a resource was most recently created before we trust the EC2 API if/when it indicates the resource doesn't exist. Signed-off-by: Nic Cope <negz@rk0n.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #802
This means we'll wait three minutes from the time a resource was most recently created before we trust the EC2 API if/when it indicates the resource doesn't exist. The crossplane-runtime bump should also make our controllers more resilient to stale controller-runtime cache reads.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I tested this change extensively as part of crossplane/crossplane-runtime#283. I've run a cursory version of the same test on this specific PR (i.e. spun a composition of EC2 resources up and down once).