feat(tgw): added ec2 tgw & tgw-vpc-attachment #831

haarchri · 2021-09-13T20:09:15Z

Signed-off-by: Christopher Haar chhaar30@googlemail.com

Description of your changes

implements ec2 tgw (transitgateway)
implements ec2 tgw-vpc-attachment (transitgateway-vpc-attachment)

transitgateway:

 kubectl describe transitgateway.ec2.aws.crossplane.io/tgw  
Name:         tgw
Namespace:    
Labels:       <none>
Annotations:  crossplane.io/external-create-pending: 2021-12-13T21:52:07+01:00
              crossplane.io/external-create-succeeded: 2021-12-13T21:52:07+01:00
              crossplane.io/external-name: tgw-0cf9ff0c1a0e88782
API Version:  ec2.aws.crossplane.io/v1alpha1
Kind:         TransitGateway
Metadata:
  Creation Timestamp:  2021-12-13T20:52:06Z
  Finalizers:
    finalizer.managedresource.crossplane.io
  Generation:  3
  Managed Fields:
    API Version:  ec2.aws.crossplane.io/v1alpha1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .:
          f:kubectl.kubernetes.io/last-applied-configuration:
      f:spec:
        .:
        f:deletionPolicy:
        f:forProvider:
          .:
          f:region:
        f:providerConfigRef:
          .:
          f:name:
    Manager:      kubectl-client-side-apply
    Operation:    Update
    Time:         2021-12-13T20:52:06Z
    API Version:  ec2.aws.crossplane.io/v1alpha1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          f:crossplane.io/external-create-pending:
          f:crossplane.io/external-create-succeeded:
          f:crossplane.io/external-name:
        f:finalizers:
          .:
          v:"finalizer.managedresource.crossplane.io":
      f:spec:
        f:forProvider:
          f:options:
            .:
            f:amazonSideASN:
            f:autoAcceptSharedAttachments:
            f:defaultRouteTableAssociation:
            f:defaultRouteTablePropagation:
            f:dnsSupport:
            f:multicastSupport:
            f:vpnECMPSupport:
          f:tags:
      f:status:
        .:
        f:atProvider:
          .:
          f:creationTime:
          f:ownerID:
          f:state:
          f:transitGatewayARN:
          f:transitGatewayID:
        f:conditions:
    Manager:         provider
    Operation:       Update
    Time:            2021-12-13T20:52:07Z
  Resource Version:  1607723
  UID:               a7f67c80-87be-4e5f-a2c9-ba8e83cf52e7
Spec:
  Deletion Policy:  Delete
  For Provider:
    Options:
      Amazon Side ASN:                  64512
      Auto Accept Shared Attachments:   disable
      Default Route Table Association:  enable
      Default Route Table Propagation:  enable
      Dns Support:                      enable
      Multicast Support:                disable
      Vpn ECMP Support:                 enable
    Region:                             us-east-1
    Tags:
      Key:    crossplane-kind
      Value:  transitgateway.ec2.aws.crossplane.io
      Key:    crossplane-name
      Value:  tgw
      Key:    crossplane-providerconfig
      Value:  example
  Provider Config Ref:
    Name:  example
Status:
  At Provider:
    Creation Time:        2021-12-13T20:52:07Z
    Owner ID:             255932642927
    State:                available
    Transit Gateway ARN:  arn:aws:ec2:us-east-1:255932642927:transit-gateway/tgw-0cf9ff0c1a0e88782
    Transit Gateway ID:   tgw-0cf9ff0c1a0e88782
  Conditions:
    Last Transition Time:  2021-12-13T20:54:09Z
    Reason:                Available
    Status:                True
    Type:                  Ready
    Last Transition Time:  2021-12-13T20:52:07Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
Events:

transitgateway-vpc-attachment:

kubectl describe transitgatewayvpcattachment.ec2.aws.crossplane.io/tgw-vpc-attach 
Name:         tgw-vpc-attach
Namespace:    
Labels:       <none>
Annotations:  crossplane.io/external-create-pending: 2021-12-13T21:55:06+01:00
              crossplane.io/external-create-succeeded: 2021-12-13T21:55:08+01:00
              crossplane.io/external-name: tgw-attach-03fb604eaeeaef23e
API Version:  ec2.aws.crossplane.io/v1alpha1
Kind:         TransitGatewayVPCAttachment
Metadata:
  Creation Timestamp:  2021-12-13T20:55:06Z
  Finalizers:
    finalizer.managedresource.crossplane.io
  Generation:  3
  Managed Fields:
    API Version:  ec2.aws.crossplane.io/v1alpha1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .:
          f:kubectl.kubernetes.io/last-applied-configuration:
      f:spec:
        .:
        f:deletionPolicy:
        f:forProvider:
          .:
          f:region:
          f:subnetIdsRefs:
          f:transitGatewayIdRef:
            .:
            f:name:
          f:vpcIdRef:
            .:
            f:name:
        f:providerConfigRef:
          .:
          f:name:
    Manager:      kubectl-client-side-apply
    Operation:    Update
    Time:         2021-12-13T20:55:06Z
    API Version:  ec2.aws.crossplane.io/v1alpha1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          f:crossplane.io/external-create-pending:
          f:crossplane.io/external-create-succeeded:
          f:crossplane.io/external-name:
        f:finalizers:
          .:
          v:"finalizer.managedresource.crossplane.io":
      f:spec:
        f:forProvider:
          f:subnetIds:
          f:tags:
          f:transitGatewayId:
          f:vpcId:
      f:status:
        .:
        f:atProvider:
          .:
          f:creationTime:
          f:state:
          f:subnetIDs:
          f:transitGatewayAttachmentID:
          f:transitGatewayID:
          f:vpcID:
          f:vpcOwnerID:
        f:conditions:
    Manager:         provider
    Operation:       Update
    Time:            2021-12-13T20:55:08Z
  Resource Version:  1608221
  UID:               1f8aef5a-2676-4215-9fc8-8f6d94809426
Spec:
  Deletion Policy:  Delete
  For Provider:
    Region:  us-east-1
    Subnet Ids:
      subnet-0bea8bdb2151f4fbe
      subnet-04be0211e759fb076
    Subnet Ids Refs:
      Name:  sample-subnet1
      Name:  sample-subnet2
    Tags:
      Key:               crossplane-kind
      Value:             transitgatewayvpcattachment.ec2.aws.crossplane.io
      Key:               crossplane-name
      Value:             tgw-vpc-attach
      Key:               crossplane-providerconfig
      Value:             example
    Transit Gateway Id:  tgw-0cf9ff0c1a0e88782
    Transit Gateway Id Ref:
      Name:  tgw
    Vpc Id:  vpc-0557e8b3073ddddad
    Vpc Id Ref:
      Name:  sample-vpc
  Provider Config Ref:
    Name:  example
Status:
  At Provider:
    Creation Time:  2021-12-13T20:55:08Z
    State:          available
    Subnet I Ds:
      subnet-0bea8bdb2151f4fbe
      subnet-04be0211e759fb076
    Transit Gateway Attachment ID:  tgw-attach-03fb604eaeeaef23e
    Transit Gateway ID:             tgw-0cf9ff0c1a0e88782
    Vpc ID:                         vpc-0557e8b3073ddddad
    Vpc Owner ID:                   255932642927
  Conditions:
    Last Transition Time:  2021-12-13T20:57:09Z
    Reason:                Available
    Status:                True
    Type:                  Ready
    Last Transition Time:  2021-12-13T20:55:08Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced

Fixes #363 #750

I have:

Read and followed Crossplane's contribution process.
Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

AaronME · 2021-09-24T17:34:59Z

@haarchri Is this still WIP or ready for review?

haarchri · 2021-09-24T17:45:05Z

@AaronME ready for review - thanks for the hint in the topic description

haarchri · 2021-11-26T10:35:01Z

still blocked by #920

haarchri · 2021-12-10T14:03:01Z

rebased & tested again after #920 was merged

NAME                                       READY   SYNCED   EXTERNAL-NAME
transitgateway.ec2.aws.crossplane.io/tgw   True    True     tgw-0d0013ce6d364d20b

NAME                                                               READY   SYNCED   EXTERNAL-NAME
transitgatewayvpcattachment.ec2.aws.crossplane.io/tgw-vpc-attach   True    True     tgw-attach-0bc3d1f136a3368a3

muvaf

I have a few comments but I think we'll get to merge it before the release.

apis/ec2/v1alpha1/custom_types.go

pkg/controller/ec2/transitgateway/setup.go

pkg/controller/ec2/transitgatewayvpcattachment/setup.go

haarchri · 2021-12-13T21:13:23Z

@muvaf changed your suggestions
also fir VPCPeeringConnection, added Tagger and changed the fields to lower camel, changed to generated referencers ;)

muvaf

I have a couple of comments but LGTM in general. As synced, having VPCPeeringConnection changes in a separate PR would be better.

apis/ec2/v1alpha1/custom_types.go

examples/ec2/transitgatewayvpcattachment.yaml

pkg/controller/ec2/transitgatewayvpcattachment/setup.go

pkg/controller/ec2/vpcpeeringconnection/setup.go

apis/ec2/v1alpha1/custom_types.go

Signed-off-by: haarchri <chhaar30@googlemail.com>

haarchri · 2021-12-14T13:42:37Z

i will open fullow up PR for cleanup vpc_peering_connection - thanks for review

Add targetgroupArnRef

haarchri mentioned this pull request Sep 13, 2021

EC2 VPC service controller aws-controllers-k8s/community#489

Closed

haarchri force-pushed the ec2-transitgateway branch from aa967a8 to 1acab54 Compare September 15, 2021 06:56

haarchri mentioned this pull request Sep 15, 2021

ec2 transitgateway code-gen problem zz_conversions.go aws-controllers-k8s/community#957

Closed

haarchri force-pushed the ec2-transitgateway branch from 2d6be25 to d209b64 Compare September 15, 2021 16:40

haarchri changed the title ~~WIP: feat(transitgateway): added ec2 transitgateway~~ WIP: feat(tgw): added ec2 tgw & tgw-vpc-attachment Sep 15, 2021

haarchri mentioned this pull request Sep 15, 2021

Support for AWS TransitGateway and TransitGatewayAttachment #363

Closed

AaronME self-assigned this Sep 24, 2021

haarchri changed the title ~~WIP: feat(tgw): added ec2 tgw & tgw-vpc-attachment~~ feat(tgw): added ec2 tgw & tgw-vpc-attachment Sep 24, 2021

This was referenced Oct 20, 2021

EC2 Route #859

Merged

MEMBERSHIP: haarchri crossplane/org#20

Closed

Excluded Resources are being included in CRDs #876

Closed

haarchri force-pushed the ec2-transitgateway branch 4 times, most recently from 2162f08 to 66bc94e Compare December 10, 2021 13:56

haarchri requested a review from AaronME December 10, 2021 14:03

muvaf reviewed Dec 13, 2021

View reviewed changes

haarchri force-pushed the ec2-transitgateway branch 3 times, most recently from 4c77aa4 to 515144c Compare December 13, 2021 21:01

haarchri added the breaking-change label Dec 13, 2021

haarchri force-pushed the ec2-transitgateway branch from 515144c to c3759de Compare December 13, 2021 21:12

haarchri force-pushed the ec2-transitgateway branch from c3759de to 209202b Compare December 13, 2021 21:22

haarchri requested a review from muvaf December 13, 2021 21:30

haarchri force-pushed the ec2-transitgateway branch from 209202b to 8f2c058 Compare December 14, 2021 09:02

muvaf approved these changes Dec 14, 2021

View reviewed changes

haarchri removed the breaking-change label Dec 14, 2021

haarchri force-pushed the ec2-transitgateway branch from 8f2c058 to 0fc4390 Compare December 14, 2021 13:09

feat(tgw): added ec2 transitgateway & transitgateway vpc attachment

5cda435

Signed-off-by: haarchri <chhaar30@googlemail.com>

haarchri force-pushed the ec2-transitgateway branch from 0fc4390 to 5cda435 Compare December 14, 2021 13:13

haarchri merged commit 8e2b6d8 into crossplane-contrib:master Dec 14, 2021

haarchri mentioned this pull request Dec 22, 2021

Implement transit gateway vpc attachment #750

Closed

tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024

Merge pull request crossplane-contrib#831 from mhoshi-vm/830

699f8d6

Add targetgroupArnRef

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(tgw): added ec2 tgw & tgw-vpc-attachment #831

feat(tgw): added ec2 tgw & tgw-vpc-attachment #831

haarchri commented Sep 13, 2021 •

edited

AaronME commented Sep 24, 2021

haarchri commented Sep 24, 2021

haarchri commented Nov 26, 2021

haarchri commented Dec 10, 2021

muvaf left a comment

haarchri commented Dec 13, 2021 •

edited

muvaf left a comment

haarchri commented Dec 14, 2021

feat(tgw): added ec2 tgw & tgw-vpc-attachment #831

feat(tgw): added ec2 tgw & tgw-vpc-attachment #831

Conversation

haarchri commented Sep 13, 2021 • edited

Description of your changes

How has this code been tested

AaronME commented Sep 24, 2021

haarchri commented Sep 24, 2021

haarchri commented Nov 26, 2021

haarchri commented Dec 10, 2021

muvaf left a comment

Choose a reason for hiding this comment

haarchri commented Dec 13, 2021 • edited

muvaf left a comment

Choose a reason for hiding this comment

haarchri commented Dec 14, 2021

haarchri commented Sep 13, 2021 •

edited

haarchri commented Dec 13, 2021 •

edited