Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rds): fix rds examples to make aurora cluster & instance possible #852

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Oct 1, 2021

Signed-off-by: haarchri chhaar30@googlemail.com

Description of your changes

changed rds examples to fits for aurora-cluster & instance and use parametergroups for cluster & instace
Fixes #842 #844

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

image

Aurora Cluster + Instance and dbClusterParameterGroup

NAME                                                                          READY   SYNCED   EXTERNAL-NAME
dbclusterparametergroup.rds.aws.crossplane.io/example-clusterparametergroup   True    True     example-clusterparametergroup
NAME                                                           READY   SYNCED   EXTERNAL-NAME
dbcluster.rds.aws.crossplane.io/example-aurora-mysql-cluster   True    True     example-aurora-mysql-cluster
NAME                                                             READY   SYNCED   EXTERNAL-NAME
dbinstance.rds.aws.crossplane.io/example-aurora-mysql-instance   True    True     example-aurora-mysql-instance

Single Instance with dbParameterGroup

image

NAME                                                             READY   SYNCED   EXTERNAL-NAME
dbinstance.rds.aws.crossplane.io/example-dbinstance              True   True     example-dbinstance
NAME                                                              READY   SYNCED   EXTERNAL-NAME
dbparametergroup.rds.aws.crossplane.io/example-dbparametergroup   True    True     example-dbparametergroup

Signed-off-by: haarchri <chhaar30@googlemail.com>
@vlewin
Copy link

vlewin commented Oct 4, 2021

Thank you very much for updating the Aurora examples!

I tested the examples with CRDs from a master branch and everything seems to work fine. However, the DBInstance and DBClusterParameterGroup CRDs and controllers are not available in the v0.19.1 release.

When can we expect the new version of AWS provider with required CRDs and controller?

Copy link
Collaborator

@chlunde chlunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testet by at least two community members, LGTM!

@chlunde chlunde merged commit d52e5ba into crossplane-contrib:master Oct 5, 2021
@chlunde
Copy link
Collaborator

chlunde commented Oct 5, 2021

Thanks @haarchri !

@haarchri haarchri mentioned this pull request Oct 21, 2021
6 tasks
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
…deliverystream-lateinit

fix(lateinit): skip version_id for firehose deliverystream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants