Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements Kinesis Stream #857

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Oct 4, 2021

Signed-off-by: haarchri chhaar30@googlemail.com

Description of your changes

  • Implements Kinesis Stream
  • example needs 4 reconciler update runs to gets all configurations updated =)

Fixes #174 #149

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • created Kinesis Stream
  • tested update for shardCount
  • tested update for retentionPeriodHours
  • tested update for enhancedMetrics
  • tested update for kmsKeyARN
  • tested update for tags
kubectl describe stream.kinesis.aws.crossplane.io/kinesis-stream
Name:         kinesis-stream
Namespace:    
Labels:       <none>
Annotations:  crossplane.io/external-create-pending: 2022-01-02T12:52:39+01:00
              crossplane.io/external-create-succeeded: 2022-01-02T12:52:39+01:00
              crossplane.io/external-name: kinesis-stream
API Version:  kinesis.aws.crossplane.io/v1alpha1
Kind:         Stream
Metadata:
  Creation Timestamp:  2022-01-02T11:52:38Z
  Finalizers:
    finalizer.managedresource.crossplane.io
  Generation:  2
  Resource Version:  2687433
  UID:               3bf91cf9-019d-4343-9f31-897091bb17d6
Spec:
  Deletion Policy:  Delete
  For Provider:
    Enhanced Metrics:
      Shard Level Metrics:
        IncomingBytes
        OutgoingBytes
    Kms Key ARN:  arn:aws:kms:us-east-1:255932642927:key/c3b672bd-5f9a-4b31-87e6-ffcabfd27b53
    Kms Key ARN Ref:
      Name:                  dev-key
    Region:                  us-east-1
    Retention Period Hours:  48
    Shard Count:             4
    Tags:
      Key:    key1
      Value:  value1
      Key:    key2
      Value:  value2
  Provider Config Ref:
    Name:  example
Status:
  At Provider:
    Encryption Type:  KMS
    Enhanced Monitoring:
      Shard Level Metrics:
        IncomingBytes
        OutgoingBytes
    Has More Shards:         false
    Key ID:                  arn:aws:kms:us-east-1:255932642927:key/c3b672bd-5f9a-4b31-87e6-ffcabfd27b53
    Retention Period Hours:  48
    Shards:
      Hash Key Range:
        Ending Hash Key:    85070591730234615865843651857942052863
        Starting Hash Key:  0
      Sequence Number Range:
        Starting Sequence Number:  49625529955180754923685112780698915494847580934061948930
      Shard ID:                    shardId-000000000000
      Hash Key Range:
        Ending Hash Key:    170141183460469231731687303715884105727
        Starting Hash Key:  85070591730234615865843651857942052864
      Sequence Number Range:
        Starting Sequence Number:  49625529955203055668883643403840451213120229295567929362
      Shard ID:                    shardId-000000000001
      Hash Key Range:
        Ending Hash Key:    255211775190703847597530955573826158591
        Starting Hash Key:  170141183460469231731687303715884105728
      Sequence Number Range:
        Starting Sequence Number:  49625529955225356414082174026981986931392877657073909794
      Shard ID:                    shardId-000000000002
      Hash Key Range:
        Ending Hash Key:    340282366920938463463374607431768211455
        Starting Hash Key:  255211775190703847597530955573826158592
      Sequence Number Range:
        Starting Sequence Number:  49625529955247657159280704650123522649665526018579890226
      Shard ID:                    shardId-000000000003
    Stream ARN:                    arn:aws:kinesis:us-east-1:255932642927:stream/kinesis-stream
    Stream Status:                 ACTIVE
  Conditions:
    Last Transition Time:  2022-01-02T11:56:44Z
    Reason:                Available
    Status:                True
    Type:                  Ready
    Last Transition Time:  2022-01-02T11:52:39Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
Events:
  Type    Reason                   Age                  From                                      Message
  ----    ------                   ----                 ----                                      -------
  Normal  CreatedExternalResource  4m39s                managed/stream.kinesis.aws.crossplane.io  Successfully requested creation of external resource
  Normal  UpdatedExternalResource  34s (x4 over 3m37s)  managed/stream.kinesis.aws.crossplane.io  Successfully requested update of external resource

@haarchri haarchri force-pushed the kinesis branch 2 times, most recently from a028801 to 80508b5 Compare October 4, 2021 14:09
@egeland egeland mentioned this pull request Dec 2, 2021
@egeland
Copy link

egeland commented Dec 2, 2021

@infinitecompute , would this be something you could review? 🙏

@rjackoby-r7
Copy link

Hi, any updates on this?

@haarchri
Copy link
Member Author

haarchri commented Jan 2, 2022

rebase done
creation, update & delete is working:

NAME                                              READY   SYNCED   EXTERNAL-NAME
stream.kinesis.aws.crossplane.io/kinesis-stream   True    True     kinesis-stream

@haarchri haarchri requested a review from AaronME January 3, 2022 17:55
@haarchri haarchri force-pushed the kinesis branch 2 times, most recently from e062a17 to 19623e9 Compare January 5, 2022 18:02
@haarchri
Copy link
Member Author

haarchri commented Jan 5, 2022

added atProvider fields - rebased and tested

Signed-off-by: haarchri <chhaar30@googlemail.com>
Copy link
Collaborator

@AaronME AaronME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Creates and deletes as advertised.

Thanks, @haarchri !

@AaronME AaronME merged commit af2bdd8 into crossplane-contrib:master Jan 6, 2022
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
…-definition

Adding aws_batch_job_definition to v1beta1 version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Kinesis support
4 participants