-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CloudFront Distribution OriginSSL support #922
Fix CloudFront Distribution OriginSSL support #922
Conversation
Signed-off-by: gstramandinoli <giuseppe.stramandinoli@vonage.com>
Signed-off-by: Steven Borrelli <steve@borrelli.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't aware of that option. Thanks @stevendborrelli !
originProtocolPolicy: "http-only" | ||
originReadTimeout: 10 | ||
originKeepaliveTimeout: 5 | ||
httpSPort: 443 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevendborrelli is this really with upper "S" httpSPort ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some case issues in the acc-generator. I am reviewing and will submit a PR to fix.
/backport |
Successfully created backport PR #923 for |
Backport failed for Please cherry-pick the changes locally. git fetch origin release-0.19
git worktree add -d .worktree/backport-922-to-release-0.19 origin/release-0.19
cd .worktree/backport-922-to-release-0.19
git checkout -b backport-922-to-release-0.19
ancref=$(git merge-base 4e81878a6050dbd219c975955a39a7463d0f375b c41d3cfb8fdfcba4fa4ff3cd49a8c06c87059ad6)
git cherry-pick -x $ancref..c41d3cfb8fdfcba4fa4ff3cd49a8c06c87059ad6 |
Description of your changes
From #915
Fixes #894.
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Tested with the following code from #894