Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MySQLServer] Make forProvider.publicNetworkAccess effective #301

Merged
merged 1 commit into from
Nov 18, 2021
Merged

[MySQLServer] Make forProvider.publicNetworkAccess effective #301

merged 1 commit into from
Nov 18, 2021

Conversation

mcbenjemaa
Copy link
Contributor

@mcbenjemaa mcbenjemaa commented Nov 8, 2021 •
edited

Description of your changes

Make spec.forProvider.publicNetworkAccess effective

Fixes #294

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@mcbenjemaa
Make forProvider.publicNetworkAccess effective for MySQLServer
58695f7 
Signed-off-by: Mohamed Chiheb <mc.benjemaa@gmail.com>
ulucinar
ulucinar approved these changes Nov 18, 2021
View reviewed changes
Copy link
Collaborator

@ulucinar ulucinar left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mcbenjemaa for the PR. LGTM.

@ulucinar ulucinar merged commit bd13ec7 into crossplane-contrib:master Nov 18, 2021
@mcbenjemaa mcbenjemaa mentioned this pull request Dec 23, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulucinar ulucinar ulucinar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement spec.forProvider.publicNetworkAccess for MySQLServer
2 participants
@mcbenjemaa @ulucinar