Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GKE cluster without Cloud Run: error on configuration #385

Closed
nlamirault opened this issue Oct 5, 2021 · 1 comment · Fixed by #437
Closed

GKE cluster without Cloud Run: error on configuration #385

nlamirault opened this issue Oct 5, 2021 · 1 comment · Fixed by #437
Labels
bug Something isn't working

Comments

@nlamirault
Copy link

nlamirault commented Oct 5, 2021

What happened?

Create a cluster with CloudRun disabled, i've got this error :

Events:
  Type     Reason                        Age                From                                         Message
  ----     ------                        ----               ----                                         -------
  Warning  CannotUpdateManagedResource   13s                managed/cluster.container.gcp.crossplane.io  cannot update managed resource: Operation cannot be fulfilled on clusters.container.gcp.crossplane.io "portefaix-krm-gcp": the object has been modified; please apply your changes to the latest version and try again
  Warning  CannotCreateExternalResource  12s (x4 over 13s)  managed/cluster.container.gcp.crossplane.io  cannot create GKE cluster: googleapi: Error 400: Invalid value at 'cluster.addons_config.cloud_run_config.load_balancer_type' (type.googleapis.com/google.container.v1.CloudRunConfig.LoadBalancerType), "", invalid

with configuration:

apiVersion: container.gcp.crossplane.io/v1beta2
kind: Cluster
metadata:
  name: portefaix-krm-gcp
spec:
  forProvider:
    location: europe-west1-c
    masterAuth:
      # setting this master auth user name enables basic auth so that a client (e.g.,
      # provider-helm), can connect with the generated kubeconfig from the connection secret
      # username: admin
    networkConfig:
      enableIntraNodeVisibility: true
   addonsConfig:
      cloudRunConfig:
        disabled: true

Works fine with:

apiVersion: container.gcp.crossplane.io/v1beta2
kind: Cluster
metadata:
  name: portefaix-krm-gcp
spec:
  forProvider:
    location: europe-west1-c
    masterAuth:
      # setting this master auth user name enables basic auth so that a client (e.g.,
      # provider-helm), can connect with the generated kubeconfig from the connection secret
      # username: admin
    networkConfig:
      enableIntraNodeVisibility: true
   addonsConfig:
      cloudRunConfig:
        disabled: true
        loadBalancerType: LOAD_BALANCER_TYPE_UNSPECIFIED

How can we reproduce it?

What environment did it happen in?

Crossplane version: 1.4
Provider GCP : 1.18.0

@nlamirault nlamirault added the bug Something isn't working label Oct 5, 2021
@edenreich
Copy link
Contributor

I can confirm this bug, had the same issue, setting cloudRunConfig to disabled requires apparently loadbalancerType...strange behaviour..

edenreich added a commit to edenreich/provider-gcp that referenced this issue May 15, 2022
edenreich added a commit to edenreich/provider-gcp that referenced this issue May 15, 2022
@edenreich edenreich mentioned this issue May 15, 2022
2 tasks
edenreich added a commit to edenreich/provider-gcp that referenced this issue May 15, 2022
… default if nothing is set

Signed-off-by: Eden <eden.reich@gmail.com>
muvaf added a commit that referenced this issue May 17, 2022
bradkwadsworth-mw pushed a commit to MavenWave-DevOps/provider-gcp that referenced this issue Sep 19, 2022
… default if nothing is set

Signed-off-by: Eden <eden.reich@gmail.com>
bradkwadsworth-mw pushed a commit to MavenWave-DevOps/provider-gcp that referenced this issue Sep 19, 2022
… default if nothing is set

Signed-off-by: Eden <eden.reich@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants