Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better member name format for roles/iam.workloadIdentityUser #390

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

terrytangyuan
Copy link
Contributor

vault-system/vault is not used anywhere in this repo so better to use the format mentioned in the reference.

Signed-off-by: Yuan Tang terrytangyuan@gmail.com

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Copy link
Collaborator

@Feggah Feggah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs a rebase for #391, but otherwise it looks good. Thank you!

@terrytangyuan
Copy link
Contributor Author

Done. Thanks!

@Feggah Feggah mentioned this pull request Oct 14, 2021
6 tasks
@turkenh turkenh merged commit 76cb3fc into crossplane-contrib:master Oct 15, 2021
@terrytangyuan terrytangyuan deleted the better-format branch October 15, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants