adding support for multiple client options on connect #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: evgenyKharitonov <evgeny@tailorbrands.com>
evgenyKharitonov
force-pushed
the
enh/provider_multiple_client_options
branch
from
c816ca6
to
311a7e6
Compare
|
@negz any thing we can do to get this merged? |
turkenh
reviewed
Jun 3, 2022
turkenh
reviewed
Jun 3, 2022
Signed-off-by: evgenyKharitonov <evgeny@tailorbrands.com>
turkenh
approved these changes
Jun 7, 2022
|
@evgenyKharitonov please check the following linter error at check-diff step: go: downloading github.com/cespare/xxhash v1.1.0
11:07:26 [ OK ] go mod tidy
11:07:26 [ .. ] checking that branch is clean
M apis/v1beta1/zz_generated.deepcopy.go
M package/crds/gcp.crossplane.io_providerconfigs.yaml
11:07:26 [FAIL]
make: *** [check-diff] Error 1
build/makelib/common.mk:[43](https://github.com/crossplane-contrib/provider-gcp/runs/6772760420?check_suite_focus=true#step:8:44)0: recipe for target 'check-diff' failed |
Signed-off-by: evgenyKharitonov <evgeny@tailorbrands.com>
|
@turkenh - updated, thanks, missed that 🙏 |
turkenh
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adding the ability to set multiple
ClientOptionsas part of theProvider/ProviderConfigCRD.Adding
endpointandwithoutAuthenticationoptions to be able to connect to other APIs except the default one and without authentication.Renamed
GetAuthInfomethod toGetConnectionInfosince it will represent better the functionality after that change.Fixes #432
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested locally using
kind- Crossplane and PubSub emulator were installed.Then I ran
provider-gcplocally (make run) with port forwarding to the cluster API and to PubSub emulator.Created new
Topicresources and saw that the resource created in the emulator (verified by REST request to emulator's API) and saw in the logs.