Release in Ready state before connection details are available

[srueg]

What happened?

Using the connectionDetails feature (#73) we read the IP of a LoadBalancer service. Unfortunately the Release resource goes to a ready state before the info was read and therefore the connection detail is missing.

How can we reproduce it?

Create a Release which reads the IP of a service:

connectionDetails:
  - apiVersion: v1
    fieldPath: status.loadBalancer.ingress[0].ip
    kind: Service
    name: haproxy
    namespace: b6d9f1ac-d636-44df-a538-5d0cc2a12e9b
    toConnectionSecretKey: endpoint

What environment did it happen in?

Crossplane version: v1.1.0
provider-helm version: v0.5.0

[srueg]

We should probably skip setting the Release to available here? https://github.com/crossplane-contrib/provider-helm/blob/master/pkg/controller/release/release.go#L313

[turkenh]

I think, this behaviour is expected since it is consistent with helm itself. For example, if you install a chart that creates a load balancer, helm installation returns success once all resources created on k8s API and the release is marked as done unless you set --wait.

I see two possible solutions/workarounds here:

• Set wait: true in release spec.
• Build the wait logic on the consumer part, who waits for connection details.

Stating this, I could also not see an immediate problem with removing the line you pointed 🤔