Set timeout for uninstall client so delete hooks don't hang. #153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bob Haddleton bob.haddleton@nokia.com
Description of your changes
Set the uninstall client timeout and wait parameters to the specified args,
The default timeout is null which causes the helm client to wait forever for delete hooks which may never complete if the cluster has been deleted.
Fixes #151
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
Soaked in our development environment for a week, which usually sees the problem multiple times.