This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Skip terraform region validation for resources without region #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hasan Turken <turkenh@gmail.com>
turkenh
changed the title
turkenh
commented
Oct 17, 2021
| @@ -83,6 +83,14 @@ func TerraformSetupBuilder(version, providerSource, providerVersion string) terr | |||
| // e.g. what about setting an assume_role section: https://registry.terraform.io/providers/hashicorp/aws/latest/docs#argument-reference | |||
| tfCfg := map[string]interface{}{} | |||
| tfCfg["region"] = awsConf.Region | |||
| if awsConf.Region == "" { | |||
| // Some resources, like iam group, do not have a notion of region | |||
There was a problem hiding this comment.
Setting region with this value didn't work as well. Terraform returned not a valid region error.
muvaf
approved these changes
Oct 17, 2021
|
Successfully created backport PR #116 for |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Some resources, like
iamgroup, do not have a notion ofregionhence we have no region in their schema.However, terraform still attempts validating region in provider config and does not like both empty string or not setting it at all. We need to skip region validation in this case.
Fixes #112
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Create a user using the example
Delete user