This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Apply tagging convention #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergenyalcin
force-pushed
the
tagging-convention
branch
from
f12bf7d
to
3fb285c
Compare
3 tasks
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
sergenyalcin
force-pushed
the
tagging-convention
branch
from
3fb285c
to
bbe5a3b
Compare
muvaf
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
LGTM! Thanks for driving this to finish @sergenyalcin ! Good to merge after addressing the append comment.
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
sergenyalcin
force-pushed
the
tagging-convention
branch
from
5069c66
to
bac1de4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #136
This PR adds tagging convention for provider-aws.
This PR depends on crossplane/terrajet#198
Until merge the dependent PR, a temporary replace command was added to go.mod.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Some example manifests were applied. Then tags of MRs and external resources were checked.