This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add Neptune API resources #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulucinar
reviewed
Jan 17, 2022
ezgidemirel
force-pushed
the
add-neptune
branch
2 times, most recently
from
fc7e387
to
5bd9c49
Compare
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
- fix typos in subnet example manifest - make snapshot taking async Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
ezgidemirel
force-pushed
the
add-neptune
branch
from
5bd9c49
to
644d60e
Compare
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
ezgidemirel
force-pushed
the
add-neptune
branch
from
644d60e
to
181e16c
Compare
|
Thanks @muvaf! it's ready to be merged now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds following Neptune related resources:
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I have tested these resources with the provided example manifests.