Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Fix ecs.Cluster external name configuration #172

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Mar 17, 2022

Description of your changes

Fixes ecs.Cluster external name configuration as reported in #168.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested provisioning and deleting a resource using the manifest:

apiVersion: ecs.aws.jet.crossplane.io/v1alpha2
kind: Cluster
metadata:
  name: alper-sample-cluster
spec:
  forProvider:
    region: us-west-2
❯ k get clusters.ecs -w
NAME                   READY   SYNCED   EXTERNAL-NAME          AGE
alper-sample-cluster                    alper-sample-cluster   3s
alper-sample-cluster                    alper-sample-cluster   11s
alper-sample-cluster                    alper-sample-cluster   11s
alper-sample-cluster                    alper-sample-cluster   11s
alper-sample-cluster   False   True     alper-sample-cluster   11s
alper-sample-cluster   False   True     alper-sample-cluster   11s
alper-sample-cluster   False   True     alper-sample-cluster   30s
alper-sample-cluster   False   True     alper-sample-cluster   35s
alper-sample-cluster   True    True     alper-sample-cluster   39s
alper-sample-cluster   True    True     alper-sample-cluster   2m30s

Also provisioned, then orphaned and deleted a resource, and then could successfully re-import it.

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Copy link
Collaborator

@turkenh turkenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ulucinar 👍

config/ecs/config.go Show resolved Hide resolved
@ulucinar ulucinar merged commit ba031a7 into crossplane-contrib:main Mar 17, 2022
@ulucinar ulucinar deleted the fix-168 branch March 17, 2022 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants