Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Fix external name configuration for ECS Service #173

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Fix external name configuration for ECS Service #173

merged 1 commit into from
Mar 17, 2022

Conversation

turkenh
Copy link
Collaborator

@turkenh turkenh commented Mar 17, 2022

Description of your changes

This PR fixes ECS Service external name configuration and adds a working/tested example.

Fixes #170

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Using the (renamed) example manifest which is also added in this PR.

kubectl get -f examples/ecs/service.yaml -w
NAME                      READY   SYNCED   EXTERNAL-NAME             AGE
sample-service-by-hasan                    sample-service-by-hasan   2s
sample-service-by-hasan                    sample-service-by-hasan   35s
sample-service-by-hasan                    sample-service-by-hasan   35s
sample-service-by-hasan                    sample-service-by-hasan   35s
sample-service-by-hasan   False   True     sample-service-by-hasan   35s
sample-service-by-hasan   False   True     sample-service-by-hasan   35s
sample-service-by-hasan   False   True     sample-service-by-hasan   59s
sample-service-by-hasan   False   True     sample-service-by-hasan   63s
sample-service-by-hasan   False   True     sample-service-by-hasan   63s
sample-service-by-hasan   True    True     sample-service-by-hasan   77s
sample-service-by-hasan   True    True     sample-service-by-hasan   111s

@turkenh turkenh requested a review from muvaf March 17, 2022 12:43
@turkenh turkenh assigned ulucinar and unassigned ulucinar Mar 17, 2022
@turkenh turkenh requested a review from ulucinar March 17, 2022 12:44
ulucinar
ulucinar reviewed Mar 17, 2022
View reviewed changes
config/ecs/config.go Outdated Show resolved Hide resolved
@turkenh
Fix external name configuration for ECS Service
c8ac7d8 
Fixes crossplane-contrib#170

Signed-off-by: Hasan Turken <turkenh@gmail.com>
(cherry picked from commit 39932472c6cd6bba3db75bdb4b8ae674fcabf995)
@turkenh turkenh merged commit cb9ae57 into crossplane-contrib:main Mar 17, 2022
@github-actions github-actions bot mentioned this pull request Mar 17, 2022
Merged
@github-actions
Copy link

Successfully created backport PR #175 for release-0.4.

@stevendborrelli stevendborrelli mentioned this pull request Mar 21, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ulucinar ulucinar ulucinar approved these changes

@muvaf muvaf Awaiting requested review from muvaf

Assignees
No one assigned
Labels
backport release-0.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ECS Service: cannot set external name
2 participants
@turkenh @ulucinar