This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add RDS SubnetGroup #186
Merged
Add RDS SubnetGroup #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
turkenh
approved these changes
Apr 29, 2022
ulucinar
approved these changes
Apr 29, 2022
| } | ||
| r.UseAsync = true | ||
| }) | ||
| p.AddResourceConfigurator("aws_db_parameter_group", func(r *config.Resource) { | ||
| r.Version = common.VersionV1Alpha2 | ||
| r.ExternalName = config.NameAsIdentifier | ||
| }) | ||
| p.AddResourceConfigurator("aws_db_subnet_group", func(r *config.Resource) { |
There was a problem hiding this comment.
Hi @ezgidemirel,
Do we already have subnet_ids configured as references?
There was a problem hiding this comment.
Yes, we have in here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ezgidemirel ezgidemirel91@gmail.com
Description of your changes
This PR adds RDS subnetGroup.
Fixes #185
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I created/deleted a subnet group and used it while creating an RDS cluster.