This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add Internet Gateway #191
Merged
Add Internet Gateway #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turkenh
approved these changes
Apr 29, 2022
ulucinar
approved these changes
Apr 29, 2022
config/ec2/config.go
Outdated
| p.AddResourceConfigurator("aws_internet_gateway", func(r *config.Resource) { | ||
| r.Version = common.VersionV1Alpha2 | ||
| r.ExternalName = config.IdentifierFromProvider | ||
| r.References["vpc_id"] = config.Reference{ |
There was a problem hiding this comment.
nit: It looks like we have a common referencer configuration vpc_id, is it not applicable here?
provider-jet-aws/config/overrides.go
Line 391 in 348ee1c
There was a problem hiding this comment.
It's applicable, removed the reference in the config.
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
ezgidemirel
force-pushed
the
internet-gateway
branch
from
3def45d
to
f33a325
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ezgidemirel ezgidemirel91@gmail.com
Description of your changes
This PR adds Internet Gateway resource.
Fixes #190
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I created/deleted the resource using the example manifest.