Add MQ broker and configuration resources #193
Conversation
There was a problem hiding this comment.
@ezgidemirel could you also fill how this code has been tested section?
| func Configure(p *config.Provider) { | ||
| p.AddResourceConfigurator("aws_mq_broker", func(r *config.Resource) { | ||
| r.Version = common.VersionV1Alpha2 | ||
| // Due to a terrajet limitation, we cannot use "metedata.name" field as the name of the resource |
There was a problem hiding this comment.
Could you put the link for that issue here?
There was a problem hiding this comment.
Hi @ezgidemirel,
This issue resembles crossplane-contrib/provider-mongodbatlas#1, although my understanding is that broker ID does not entail any piece of information from spec.forProvider. But still, if I'm not mistaken, crossplane-contrib/provider-mongodbatlas#1 is a generalized version of what you have encountered.
There was a problem hiding this comment.
Yes, looks like it is. I tried to apply some workarounds to omit name fields, but couldn't be successful.
| metadata: | ||
| name: example | ||
| spec: | ||
| forProvider: |
There was a problem hiding this comment.
I note here on why we need the brokerName here instead of reusing metadata.name would be helpful.
| metadata: | ||
| name: example | ||
| spec: | ||
| forProvider: |
There was a problem hiding this comment.
Same here, please add a note.
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
ezgidemirel
force-pushed
the
add-mq-broker
branch
from
715e387
to
23b80f3
Compare
|
Thanks a lot @turkenh for your review! |
Signed-off-by: ezgidemirel ezgidemirel91@gmail.com
Description of your changes
This PR adds MQ configuration and broker resources.
Fixes #192
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I created/deleted an MQ broker and a configuration using example manifests.