Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

feat(elasticache): added elasticache subnetgroup, fixed replicationgroup #199

Merged

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented May 8, 2022

Signed-off-by: haarchri chhaar30@googlemail.com

Description of your changes

  • added elasticache subnetgroup
  • fixed replicationgroup created (async true) & synced (skip lateinit fields)
  • created ref/selector for subnetgroup in replicationgroup and cluster
  • added example for elasticache subnetgroup
  • added example for elasticache replicationgroup
  • changed ec2/subnet to fits us-west-1a

Fixes #195 #196

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

NAME                                                                READY   SYNCED   EXTERNAL-NAME         AGE
subnetgroup.elasticache.aws.jet.crossplane.io/example-subnetgroup   True    True     example-subnetgroup   86m

NAME                                                                          READY   SYNCED   EXTERNAL-NAME              AGE
replicationgroup.elasticache.aws.jet.crossplane.io/example-replicationgroup   True    True     example-replicationgroup   23m

…oup create & synced, added examples

Signed-off-by: haarchri <chhaar30@googlemail.com>
…he clusters

Signed-off-by: haarchri <chhaar30@googlemail.com>
Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@muvaf muvaf merged commit 9f5f8e9 into crossplane-contrib:main May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconciliation fails for elasticache replication group
3 participants