Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

fix(eks-nodegroup): fix nodegroup and add more example for provisioning #201

Merged
merged 1 commit into from
May 26, 2022

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented May 8, 2022

Signed-off-by: haarchri chhaar30@googlemail.com

Description of your changes

  • add example for eks nodegroup
  • fix issue for eks nodegroup with unexpected format for ID (), expected cluster-name:node-group-name:
  • add example for eks nodegroup iam role/attchment

Fixes #187

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

NAME                                                   READY   SYNCED   EXTERNAL-NAME        AGE
cluster.eks.aws.jet.crossplane.io/sample-eks-cluster   True    True     sample-eks-cluster   39m

NAME                                                READY   SYNCED   EXTERNAL-NAME   AGE
nodegroup.eks.aws.jet.crossplane.io/sample-eks-ng   True   True     sample-eks-ng   28m

NAME                                                READY   SYNCED   EXTERNAL-NAME        AGE
role.iam.aws.jet.crossplane.io/sample-eks-cluster   True    True     sample-eks-cluster   7h34m
role.iam.aws.jet.crossplane.io/sample-node-role     True    True     sample-node-role     31m

NAME                                                                            READY   SYNCED   EXTERNAL-NAME                                   AGE
rolepolicyattachment.iam.aws.jet.crossplane.io/sample-cluster-policy            True    True     sample-eks-cluster-20220508185853757700000001   41m
rolepolicyattachment.iam.aws.jet.crossplane.io/sample-node-group-cni-policy     True    True     sample-node-role-20220508193956943000000001     31m
rolepolicyattachment.iam.aws.jet.crossplane.io/sample-node-group-ecr-policy     True    True     sample-node-role-20220508190934091000000001     31m
rolepolicyattachment.iam.aws.jet.crossplane.io/sample-node-group-eks-policy     True    True     sample-node-role-20220508190918097700000001     31m
rolepolicyattachment.iam.aws.jet.crossplane.io/sample-vpc-resource-controller   True    True     sample-eks-cluster-20220508194005305700000001   40m

Signed-off-by: haarchri <chhaar30@googlemail.com>
Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@muvaf muvaf merged commit 36b0c59 into crossplane-contrib:main May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create nodegroup
2 participants