Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

bug in file cluster/images/provider-jet-github-controller/Dockerfile #25

Open
perlinger opened this issue Apr 14, 2022 · 2 comments
Open
Labels
bug Something isn't working

Comments

@perlinger
Copy link

perlinger commented Apr 14, 2022

What happened?

Get error. File to remove does not exist

How can we reproduce it?

make build or make publish

What environment did it happen in?

NA

@perlinger perlinger added the bug Something isn't working label Apr 14, 2022
@perlinger
Copy link
Author

My workaround was to change
From:
&& rm /tmp/${TERRAFORM_PROVIDER_DOWNLOAD_NAME}${TERRAFORM_PROVIDER_VERSION}linux${ARCH}.zip
To:
&& rm ${PLUGIN_DIR}/tmp/${TERRAFORM_PROVIDER_DOWNLOAD_NAME}
${TERRAFORM_PROVIDER_VERSION}linux${ARCH}.zip \

@sboschman
Copy link

sboschman commented Jul 12, 2022

Those zip files are already added to a layer using the ADD command. What is the point of 'removing' them as the image size won't be affected? Probably better to just use curl/wget in the RUN command to fetch the zip files and remove them in the same RUN command to minimise layer size.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants