Fix lint and build #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sverre Boschman <1142569+sboschman@users.noreply.github.com>
ytsarev
reviewed
Jul 13, 2022
Signed-off-by: Sverre Boschman <1142569+sboschman@users.noreply.github.com>
sboschman
force-pushed
the
fix-docker-build
branch
from
d14d0ac
to
7aa3665
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Bump golangci-lint to be compatible with go 1.18
Removes the native terraform provider binary install, upstream terraform-provider-rancher2 does not seem to be compiled that way. It causes the same build error as crossplane-contrib/provider-jet-template#25
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
run
make build