Using TARGETARCH to capture arch-appropriate terraform binaries #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Eaton <aaron@upbound.io>
|
cc @hasheddan who is more familiar with the build steps here. |
hasheddan
requested changes
Mar 25, 2022
|
I was under the impression that TARGETARCH was a product of the build submodule. TIL it's a buildx var that the build submodule is manipulating. |
Signed-off-by: Aaron Eaton <aaron@upbound.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
We are seeing errors running builds on Mac M1 machines. Investigating the builds on dockerhub we see that both the arm and amd images are pulling amd binaries.
Setting ARCH Build Arg from TARGETARCH to get proper binaries in each image.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Built locally to confirm the change is non-breaking.