Add appropriate testing to provider-kafka for acl.go #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated with Syft tool from Anchore
adding provider-kafka sbom
Create sbom
Testing topic client
removed additional generate cases
Added: client/topic unit testing using tdd, updated error handling w/constants, and create sbom
# Conflicts: # go.mod
Signed-off-by: Steven Borrelli <steve@borrelli.org>
ACL test fixes
…-client Testing acl client
Add test case in for acl client comparison
Signed-off-by: Jon Graca <jon.graca@libertymutual.com>
Signed-off-by: Jon Graca <jon.graca@libertymutual.com>
jograca
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Created unit tests to validate the acl comparison functions return proper values
Fixes #21
I have:
Read and followed Crossplane's contribution process.
How has this code been tested
this pr is for unit testing, for the acl client. all tests passed for the included tests