Add appropriate testing to provider-kafka for acl.go

.gitignore

@@ -10,3 +10,5 @@ kc.json
 # ignore IDE folders
 .vscode/
 .idea/
+kaf.yaml
+local-test-scripts/*

README.md

@@ -26,7 +26,6 @@ manage [Kafka](https://kafka.apache.org/) resources.
     ```
     kubectl -n crossplane-system create secret generic kafka-creds --from-file=credentials=kc.json
     ```
-
 3. Create a `ProviderConfig`, see [this](examples/provider/config.yaml) as an example.
 
 
@@ -77,7 +76,7 @@ parameters [here](https://github.com/bitnami/charts/tree/master/bitnami/kafka/#i
    ```
    Once this file is created, apply it by running the following command
     ```bash
-    kubectl -n default create secret generic kafka-creds --from-file=credentials=kc.json
+    kubectl -n kafka-cluster create secret generic kafka-creds --from-file=credentials=kc.json
     ```
 
 3. Install [kubefwd](https://github.com/txn2/kubefwd#os).

apis/acl/v1alpha1/acl_types.go

@@ -29,7 +29,7 @@ import (
 type AccessControlListParameters struct {
 	// +kubebuilder:validation:Enum=Unknown;Any;Topic;Group;Cluster;TransactionalID
 	ResourceType string `json:"resourceType"`
-	Principle    string `json:"principle"`
+	Principal    string `json:"principal"`
 	Host         string `json:"host"`
 	// +kubebuilder:validation:Enum=Unknown;Any;All;Read;Write;Create;Delete;Alter;Describe;ClusterAction;DescribeConfigs;AlterConfigs;IdempotentWrite
 	Operation string `json:"operation"`

examples/acl/acl.yaml

@@ -7,7 +7,7 @@ spec:
     # Valid values are: Any, Topic, Group,
     # Cluster, TransactionalID
     resourceType: "Topic"
-    principle: "User:Mal"
+    principal: "User:Mal"
     host: "*"
     # Valid values are: Unknown, Any, All, Read, Write,
     # Create, Delete, Alter, Describe, ClusterAction,

internal/clients/kafka/acl/acl.go

@@ -18,7 +18,7 @@ import (
 type AccessControlList struct {
 	Name                      string `json:"Name"`
 	ResourceType              string `json:"ResourceType"`
-	Principle                 string `json:"Principle"`
+	Principal                 string `json:"Principal"`
 	Host                      string `json:"Host"`
 	Operation                 string `json:"Operation"`
 	PermissionType            string `json:"PermissionType"`
@@ -41,7 +41,7 @@ func List(ctx context.Context, cl *kadm.Client, accessControlList *AccessControl
 	}
 
 	b := kadm.ACLBuilder{}
-	ab := b.Topics(accessControlList.Name).Allow(accessControlList.Principle).AllowHosts(accessControlList.Host).Operations(ao[0]).ResourcePatternType(rpt)
+	ab := b.Topics(accessControlList.Name).Allow(accessControlList.Principal).AllowHosts(accessControlList.Host).Operations(ao[0]).ResourcePatternType(rpt)
 
 	resp, err := cl.DescribeACLs(ctx, ab)
 
@@ -57,7 +57,7 @@ func List(ctx context.Context, cl *kadm.Client, accessControlList *AccessControl
 
 	acl := AccessControlList{}
 	acl.ResourceType = accessControlList.ResourceType
-	acl.Principle = accessControlList.Principle
+	acl.Principal = accessControlList.Principal
 	acl.Host = accessControlList.Host
 	acl.Operation = accessControlList.Operation
 	acl.PermissionType = accessControlList.PermissionType
@@ -75,7 +75,7 @@ func Create(ctx context.Context, cl *kadm.Client, accessControlList *AccessContr
 	rpt, _ := kmsg.ParseACLResourcePatternType(strings.ToLower(accessControlList.ResourcePatternTypeFilter))
 
 	b := kadm.ACLBuilder{}
-	ab := b.Allow(accessControlList.Principle).AllowHosts(accessControlList.Host).Operations(ao[0]).ResourcePatternType(rpt)
+	ab := b.Allow(accessControlList.Principal).AllowHosts(accessControlList.Host).Operations(ao[0]).ResourcePatternType(rpt)
 
 	switch accessControlList.ResourceType {
 	case "Topic":
@@ -108,7 +108,7 @@ func Delete(ctx context.Context, cl *kadm.Client, accessControlList *AccessContr
 	rpt, _ := kmsg.ParseACLResourcePatternType(strings.ToLower(accessControlList.ResourcePatternTypeFilter))
 
 	b := kadm.ACLBuilder{}
-	ab := b.Topics(accessControlList.Name).Allow(accessControlList.Principle).AllowHosts(accessControlList.Host).Operations(ao[0]).ResourcePatternType(rpt)
+	ab := b.Topics(accessControlList.Name).Allow(accessControlList.Principal).AllowHosts(accessControlList.Host).Operations(ao[0]).ResourcePatternType(rpt)
 
 	resp, err := cl.DeleteACLs(ctx, ab)
 	if err != nil {
@@ -151,7 +151,7 @@ func Generate(name string, params *v1alpha1.AccessControlListParameters) *Access
 	acl := &AccessControlList{
 		Name:                      name,
 		ResourceType:              params.ResourceType,
-		Principle:                 params.Principle,
+		Principal:                 params.Principal,
 		Host:                      params.Host,
 		Operation:                 params.Operation,
 		PermissionType:            params.PermissionType,
@@ -168,7 +168,7 @@ func IsUpToDate(in *v1alpha1.AccessControlListParameters, observed *AccessContro
 	if in.ResourceType != observed.ResourceType {
 		return false
 	}
-	if in.Principle != observed.Principle {
+	if in.Principal != observed.Principal {
 		return false
 	}
 	if in.Host != observed.Host {