Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idpmapper resource and samlclient resources #77

Merged

Conversation

denniskniep
Copy link
Contributor

Description of your changes

Adds the Resources:

  • keycloak_custom_identity_provider_mapper
  • keycloak_saml_client
  • keycloak_saml_client_default_scopes
  • keycloak_saml_client_scope

I have the following question:
keycloak_custom_identity_provider_mapper has the property identity_provider_alias. But it can be either of type keycloak_saml_identity_provider or keycloak_oidc_identity_provider. How can we add this as a reference?

func Configure(p *config.Provider) {
	p.AddResourceConfigurator("keycloak_custom_identity_provider_mapper", func(r *config.Resource) {
		r.ShortGroup = Group
		r.References["realm"] = config.Reference{
			Type: "github.com/crossplane-contrib/provider-keycloak/apis/realm/v1alpha1.Realm",
		}
		r.References["identityProviderAlias"] = config.Reference{
			Type: "???",
		}
	})
}

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

FYI: I had problems running linter with version due to this bug. Therefore I used version v1.57.1

How has this code been tested

With Keycloak runing inside K8s

Signed-off-by: Dennis Kniep <kniepdennis@gmail.com>
Signed-off-by: Dennis Kniep <kniepdennis@gmail.com>
Signed-off-by: Dennis Kniep <kniepdennis@gmail.com>
@denniskniep denniskniep changed the title Feature/idpmapper and saml client idpmapper resource and samlclient resources Mar 26, 2024
@Breee Breee merged commit d15573b into crossplane-contrib:main Apr 11, 2024
7 checks passed
@Breee
Copy link
Collaborator

Breee commented Apr 11, 2024

thx alot!

should be available shortly in v0.15.0

@Breee
Copy link
Collaborator

Breee commented Apr 11, 2024

And regarding your question, i think you need to open an issue here: https://github.com/mrparkers/terraform-provider-keycloak such that we can define a keycloak_generic_identity_provider.

Similar to mrparkers/terraform-provider-keycloak#813 - i never got an answer there tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants