Skip to content

Commit

Permalink
docs: switch to upbound-system namespace everywhere for consistency
Browse files Browse the repository at this point in the history
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
  • Loading branch information
phisco committed May 23, 2023
1 parent 4b05bd0 commit d84a204
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions README.md
Expand Up @@ -57,15 +57,15 @@ sudo kubectl proxy --port=8081
1. If provider kubernetes running in the cluster (e.g. provider installed with crossplane):

```
SA=$(kubectl -n crossplane-system get sa -o name | grep provider-kubernetes | sed -e 's|serviceaccount\/|crossplane-system:|g')
SA=$(kubectl -n upbound-system get sa -o name | grep provider-kubernetes | sed -e 's|serviceaccount\/|upbound-system:|g')
kubectl create clusterrolebinding provider-kubernetes-admin-binding --clusterrole cluster-admin --serviceaccount="${SA}"
kubectl apply -f examples/provider/config-in-cluster.yaml
```
1. If provider kubernetes running outside the cluster (e.g. running locally with `make run`)

```
KUBECONFIG=$(kind get kubeconfig --name local-dev | sed -e 's|server:\s*.*$|server: http://localhost:8081|g')
kubectl -n crossplane-system create secret generic cluster-config --from-literal=kubeconfig="${KUBECONFIG}"
kubectl -n upbound-system create secret generic cluster-config --from-literal=kubeconfig="${KUBECONFIG}"
kubectl apply -f examples/provider/config.yaml
```

Expand Down
12 changes: 6 additions & 6 deletions examples/in-composition/composition.yaml
Expand Up @@ -3,7 +3,7 @@ kind: Composition
metadata:
name: argocdclusters.example.crossplane.io
spec:
writeConnectionSecretsToNamespace: crossplane-system
writeConnectionSecretsToNamespace: upbound-system
compositeTypeRef:
apiVersion: example.crossplane.io/v1alpha1
kind: ArgocdCluster
Expand Down Expand Up @@ -54,7 +54,7 @@ spec:
- us-central1-a
- us-central1-f
writeConnectionSecretToRef:
namespace: crossplane-system
namespace: upbound-system
patches:
- fromFieldPath: "metadata.name"
toFieldPath: "metadata.annotations[crossplane.io/external-name]"
Expand Down Expand Up @@ -122,7 +122,7 @@ spec:
credentials:
source: Secret
secretRef:
namespace: crossplane-system
namespace: upbound-system
key: kubeconfig
patches:
- fromFieldPath: metadata.name
Expand Down Expand Up @@ -169,7 +169,7 @@ spec:
toConnectionSecretKey: argocd-password
skipPartOfReleaseCheck: true
writeConnectionSecretToRef:
namespace: crossplane-system
namespace: upbound-system
patches:
- fromFieldPath: metadata.name
toFieldPath: spec.providerConfigRef.name
Expand All @@ -190,7 +190,7 @@ spec:
credentials:
source: Secret
secretRef:
namespace: crossplane-system
namespace: upbound-system
key: kubeconfig
patches:
- fromFieldPath: metadata.name
Expand Down Expand Up @@ -237,7 +237,7 @@ spec:
fieldPath: spec.ports[0].port
toConnectionSecretKey: port
writeConnectionSecretToRef:
namespace: crossplane-system
namespace: upbound-system
connectionDetails:
- fromConnectionSecretKey: host
- fromConnectionSecretKey: port
Expand Down
2 changes: 1 addition & 1 deletion examples/provider/config-in-cluster.yaml
@@ -1,7 +1,7 @@
# Make sure provider-kubernetes has enough permissions to install your objects into cluster
#
# You can give admin permissions by running:
# SA=$(kubectl -n crossplane-system get sa -o name | grep provider-kubernetes | sed -e 's|serviceaccount\/|crossplane-system:|g')
# SA=$(kubectl -n upbound-system get sa -o name | grep provider-kubernetes | sed -e 's|serviceaccount\/|upbound-system:|g')
# kubectl create clusterrolebinding provider-kubernetes-admin-binding --clusterrole cluster-admin --serviceaccount="${SA}"
apiVersion: kubernetes.crossplane.io/v1alpha1
kind: ProviderConfig
Expand Down
8 changes: 4 additions & 4 deletions examples/provider/config.yaml
@@ -1,7 +1,7 @@
#apiVersion: v1
#kind: Secret
#metadata:
# namespace: crossplane-system
# namespace: upbound-system
# name: example-provider-secret
#type: Opaque
#data:
Expand All @@ -15,13 +15,13 @@ spec:
credentials:
source: Secret
secretRef:
namespace: crossplane-system
namespace: upbound-system
name: cluster-config
key: kubeconfig
# identity:
# type: GoogleApplicationCredentials
# source: Secret
# secretRef:
# name: gcp-credentials
# namespace: crossplane-system
# key: credentials.json
# namespace: upbound-system
# key: credentials.json

0 comments on commit d84a204

Please sign in to comment.