fix MSSQL database user bug #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: arielsepton <arielsepton1@gmail.com>
Signed-off-by: arielsepton <arielsepton1@gmail.com>
Signed-off-by: arielsepton <64063409+arielsepton@users.noreply.github.com>
Signed-off-by: arielsepton <64063409+arielsepton@users.noreply.github.com>
mariusziemke
pushed a commit
to edudip/provider-sql
that referenced
this pull request
Jun 10, 2024
* fix mssql user bug Signed-off-by: arielsepton <arielsepton1@gmail.com> * revert test file Signed-off-by: arielsepton <arielsepton1@gmail.com> * fix test Signed-off-by: arielsepton <64063409+arielsepton@users.noreply.github.com> * gofmt -s -w Signed-off-by: arielsepton <64063409+arielsepton@users.noreply.github.com> * remove redundent print and edd better error messages Signed-off-by: arielsepton <64063409+arielsepton@users.noreply.github.com> --------- Signed-off-by: arielsepton <arielsepton1@gmail.com> Signed-off-by: arielsepton <64063409+arielsepton@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #158
Description
This pull request addresses the issue reported in #158 , where creating an MSSQL user was failing due to the error "cannot create user: mssql: You can only create a user with a password in a contained database."
Changes Made
Related Issues
Fixes #158