Injected identity #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisdavim
force-pushed
the
injected_identity
branch
from
eae320f
to
5f4a080
Compare
Signed-off-by: Luis Davim <luis.davim@sendoso.com>
Signed-off-by: Luis Davim <luis.davim@sendoso.com>
Signed-off-by: Luis Davim <luis.davim@sendoso.com>
luisdavim
force-pushed
the
injected_identity
branch
from
5f4a080
to
f16f78b
Compare
ytsarev
requested changes
Aug 3, 2022
|
These were automatically done by my IDE. I'll revert them. |
This reverts commit ba13985. Signed-off-by: Luis Davim <luis.davim@sendoso.com>
luisdavim
force-pushed
the
injected_identity
branch
from
684edd6
to
2e5a3ee
Compare
|
Done, I've reverted the commit with the linter changes, should I open a separate PR for that? |
|
@luisdavim yes, please. I think you have a similar linting config with @vglafirov, it popped up in his previous PRs :) So it would be great if we solve the markdown styling once and for all |
ytsarev
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
InjectedIdentitywas wrongly advertised as a valid credentials source for the provider config.Fixes #70
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I have manually tested the setup in a real EKS cluster.