-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add references to iot TopicRule #1055
base: main
Are you sure you want to change the base?
Conversation
/test-examples="examples/iot/topicrule-kafka.yaml" |
/test-examples="examples/iot/topicrule-cloudwatchlogs.yaml" |
/test-examples="examples/iot/topicrule-dynamodb.yaml" |
/test-examples="examples/iot/topicrule-dynamodbv2.yaml" |
/test-examples="examples/iot/topicrule-kafka.yaml" |
/test-examples="examples/iot/topicrule-dynamodb.yaml" |
/test-examples="examples/iot/topicrule-kinesis.yaml" |
/test-examples="examples/iot/topicrule-firehose.yaml" |
I think I'm going to need some help from someone at Upbound to clean up some orphaned resources in the AWS account used by uptest. The first run of the topicrule-kafka example failed because I wasn't using ${data.aws_account_id}. I think that when the test timed out, it didn't evaluate the pre-deletion hook which makes sure to delete the iot TopicRuleDestination before deleting the IAM role it uses to clean up its ENIs. As a result, the created VPC still had resources left in it, and failed its deletion. Then when I fixed the example and reran, I got an error creating the vpc that there were too many VPCs in the account in us-east-2. IIRC the default VPC limit is 5 per region, so it would be great if aws could increase that for accounts used to test IaC. I think you can just submit a quota increase request. TL;DR there's at least one VPC with a couple unused ENIs in it in us-east-2 that need to be deleted. @jeanduplessis is this something you could help with? |
/test-examples="examples/iot/topicrule-timestream.yaml" |
/test-examples="examples/iot/topicrule-stepfunction.yaml" |
/test-examples="examples/iot/topicrule-s3.yaml" |
@mbbush not to worry about orphaned resources for failed runs. We have a process that goes and kills all resources in the AWS account we use for uptest on a regular cadence. |
/test-examples="examples/iot/topicrule-kafka.yaml" |
Signed-off-by: Matt Bush <mbbush@gmail.com>
Signed-off-by: Matt Bush <mbbush@gmail.com>
Signed-off-by: Matt Bush <mbbush@gmail.com>
Signed-off-by: Matt Bush <mbbush@gmail.com>
Signed-off-by: Matt Bush <mbbush@gmail.com>
3726ea9
to
96f7175
Compare
Are you still interested in taking this PR forward, @mbbush? |
Description of your changes
Fixes #
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested