Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add references to iot TopicRule #1055

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mbbush
Copy link
Collaborator

@mbbush mbbush commented Jan 2, 2024

Description of your changes

Fixes #

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@mbbush
Copy link
Collaborator Author

mbbush commented Jan 3, 2024

/test-examples="examples/iot/topicrule-kafka.yaml"

@mbbush
Copy link
Collaborator Author

mbbush commented Jan 3, 2024

/test-examples="examples/iot/topicrule-cloudwatchlogs.yaml"

@mbbush
Copy link
Collaborator Author

mbbush commented Jan 3, 2024

/test-examples="examples/iot/topicrule-dynamodb.yaml"

@mbbush
Copy link
Collaborator Author

mbbush commented Jan 3, 2024

/test-examples="examples/iot/topicrule-dynamodbv2.yaml"

@mbbush
Copy link
Collaborator Author

mbbush commented Jan 3, 2024

/test-examples="examples/iot/topicrule-kafka.yaml"

@mbbush
Copy link
Collaborator Author

mbbush commented Jan 3, 2024

/test-examples="examples/iot/topicrule-dynamodb.yaml"

@mbbush
Copy link
Collaborator Author

mbbush commented Jan 3, 2024

/test-examples="examples/iot/topicrule-kinesis.yaml"

@mbbush
Copy link
Collaborator Author

mbbush commented Jan 3, 2024

/test-examples="examples/iot/topicrule-firehose.yaml"

@mbbush
Copy link
Collaborator Author

mbbush commented Jan 3, 2024

I think I'm going to need some help from someone at Upbound to clean up some orphaned resources in the AWS account used by uptest.

The first run of the topicrule-kafka example failed because I wasn't using ${data.aws_account_id}. I think that when the test timed out, it didn't evaluate the pre-deletion hook which makes sure to delete the iot TopicRuleDestination before deleting the IAM role it uses to clean up its ENIs. As a result, the created VPC still had resources left in it, and failed its deletion.

Then when I fixed the example and reran, I got an error creating the vpc that there were too many VPCs in the account in us-east-2. IIRC the default VPC limit is 5 per region, so it would be great if aws could increase that for accounts used to test IaC. I think you can just submit a quota increase request.

TL;DR there's at least one VPC with a couple unused ENIs in it in us-east-2 that need to be deleted.

@jeanduplessis is this something you could help with?

@mbbush
Copy link
Collaborator Author

mbbush commented Jan 3, 2024

/test-examples="examples/iot/topicrule-timestream.yaml"

@mbbush
Copy link
Collaborator Author

mbbush commented Jan 3, 2024

/test-examples="examples/iot/topicrule-stepfunction.yaml"

@mbbush
Copy link
Collaborator Author

mbbush commented Jan 3, 2024

/test-examples="examples/iot/topicrule-s3.yaml"

@jeanduplessis
Copy link
Collaborator

@mbbush not to worry about orphaned resources for failed runs. We have a process that goes and kills all resources in the AWS account we use for uptest on a regular cadence.

@mbbush
Copy link
Collaborator Author

mbbush commented Jan 12, 2024

/test-examples="examples/iot/topicrule-kafka.yaml"

Signed-off-by: Matt Bush <mbbush@gmail.com>
Signed-off-by: Matt Bush <mbbush@gmail.com>
Signed-off-by: Matt Bush <mbbush@gmail.com>
Signed-off-by: Matt Bush <mbbush@gmail.com>
Signed-off-by: Matt Bush <mbbush@gmail.com>
Signed-off-by: Matt Bush <mbbush@gmail.com>
Signed-off-by: Matt Bush <mbbush@gmail.com>
@turkenf
Copy link
Collaborator

turkenf commented Mar 26, 2024

Are you still interested in taking this PR forward, @mbbush?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants