Bump upjet to v1.1.1 #1160
Merged
Bump upjet to v1.1.1 #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-examples="examples/ec2/vpc.yaml" |
3 tasks
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
- Extend the example manifest for the Firewall.networkfirewall resource with some extra parameters and enable the update tests on it. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
force-pushed
the
release-0.47-old-sdk
branch
from
94e0df6
to
e8b5f1a
Compare
|
/test-examples="examples/networkfirewall/firewall.yaml" |
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
|
/test-examples="examples/ec2/vpc.yaml" |
sergenyalcin
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Thanks @ulucinar LGTM!
Because of the shared runner out-of-memory issues, for now, we ran the following jobs locally:
check-diff(locally passed) ✅unit-tests(locally passed) ✅
Also, the uptest runs cover the local-deploy job. In other words, in uptest runs, we ensure that the packages are correctly deployed because the work done in local-deploy is done. lint failure is also a known issue because of memory issue.
ulucinar
merged commit 294a33a
into
crossplane-contrib:release-0.47
6 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR bumps the upjet version to
v1.1.1and crossplane-runtime to commit7fcb8c5cad6fto consume the latest fixes. It also addresses an update loop issue for theFirewall.networkfirewallresource. The example manifest of theFirewall.networkfirewallresource is extended with the following two parameters:We have also enabled the update tests on this resource.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Via the following uptest runs:
VPC.ec2-> https://github.com/upbound/provider-aws/actions/runs/7930558294Firewall.networkfirewall(with update step) -> https://github.com/upbound/provider-aws/actions/runs/7930174691