re-order columns for handwritten ClusterAuth.eks #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbbush
force-pushed
the
swap-clusterauth-printer
branch
from
d4fb349
to
45be2cb
Compare
|
/test-examples="examples/eks/v1beta1/clusterauth.yaml" |
Signed-off-by: Matt Bush <mbbush@gmail.com>
turkenf
force-pushed
the
swap-clusterauth-printer
branch
from
45be2cb
to
76dce07
Compare
|
/test-examples="examples/eks/v1beta1/clusterauth.yaml" |
turkenf
approved these changes
Jun 7, 2024
|
Thank you @mbbush 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
There was a recent change in upjet that swapped the order of the Ready and Synced columns in the generated managed resource CRDs. That's already been merged and released in provider-upjet-aws. However, we forgot about ClusterAuth.eks, which is the only (I think?) CRD that's not generated by upjet.
The result is that currently when listing managed resources, for all MR kinds other than ClusterAuth, Synced appears before Ready, but for ClusterAuth, Ready appears before synced.
This PR fixes that.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Using uptest on this PR and manually: