-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 8 #161
Issue 8 #161
Conversation
/test-examples="examples/cur/reportdefinition.yaml,examples/dataexchange/dataset.yaml,examples/dataexchange/revision.yaml,examples/datapipeline/pipeline.yaml,examples/configservice/configurationaggregator.yaml,examples/configservice/remediationconfiguration.yaml" |
/test-examples="examples/cur/reportdefinition.yaml,examples/dataexchange/dataset.yaml,examples/dataexchange/revision.yaml,examples/datapipeline/pipeline.yaml,examples/configservice/configurationaggregator.yaml,examples/configservice/remediationconfiguration.yaml" |
examples/dataexchange/revision.yaml
Outdated
matchLabels: | ||
testing.upbound.io/example-name: example | ||
region: us-west-1 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove empty lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still seeing empty lines, did you forget to commit/push ?
@mykolalosev, thanks for the PR. |
/test-examples="examples/cur/reportdefinition.yaml" |
/test-examples="examples/dataexchange/dataset.yaml" |
/test-examples="examples/cur/reportdefinition.yaml" |
/test-examples="examples/dataexchange/dataset.yaml" |
/test-examples="examples/dataexchange/revision.yaml" |
/test-examples="examples/datapipeline/pipeline.yaml" |
/test-examples="examples/configservice/configurationaggregator.yaml" |
/test-examples="examples/configservice/remediationconfiguration.yaml" |
/test-examples="examples/cur/reportdefinition.yaml" |
"s3:GetBucketAcl", | ||
"s3:GetBucketPolicy" | ||
], | ||
"Resource":"arn:aws:s3:::test-definition-bucket-*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we revert wildcards here (and a couple of more below) as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's up to you. Unlike the BucketPolicy, in the Policy wildcards work well.
examples/dataexchange/revision.yaml
Outdated
matchLabels: | ||
testing.upbound.io/example-name: example | ||
region: us-west-1 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still seeing empty lines, did you forget to commit/push ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mykolalosev, looking great 👍
Description of your changes
Adds the following resources:
aws_cur_report_definition
aws_dataexchange_data_set
aws_dataexchange_revision
aws_datapipeline_pipeline
Fixes #8
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Manually and Uptest:
cur_report_definition: https://github.com/upbound/provider-aws/actions/runs/3548136037
aws_dataexchange_data_set: https://github.com/upbound/provider-aws/actions/runs/3532575085
aws_dataexchange_revision: https://github.com/upbound/provider-aws/actions/runs/3532920082
aws_datapipeline_pipeline: https://github.com/upbound/provider-aws/actions/runs/3535890761
aws_config_configuration_aggregator: https://github.com/upbound/provider-aws/actions/runs/3538339476
aws_config_remediation_configuration: https://github.com/upbound/provider-aws/actions/runs/3538408052