Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Terraform provider version to v4.66.0 #697

Merged
merged 2 commits into from
May 15, 2023

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented May 8, 2023

Description of your changes

Bumps Terraform provider version to v4.66.0.

Fixes: #684

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Breaking CRD schema changes

  • appautoscaling.aws.upbound.io_policies.yaml, Manually
NAME                                                              READY   SYNCED   EXTERNAL-NAME                AGE
policy.appautoscaling.aws.upbound.io/dynamodb-table-read-policy   True    True     dynamodb-table-read-policy   7m13s

NAME                                                              READY   SYNCED   EXTERNAL-NAME   AGE
target.appautoscaling.aws.upbound.io/dynamodb-table-read-target   True    True     table/table     7m13s

NAME                                  READY   SYNCED   EXTERNAL-NAME   AGE
table.dynamodb.aws.upbound.io/table   True    True     table           7m13s
NAME                                        READY   SYNCED   EXTERNAL-NAME   AGE
policy.autoscaling.aws.upbound.io/example   True    True     example         54m

NAME                                                     READY   SYNCED   EXTERNAL-NAME   AGE
launchconfiguration.autoscaling.aws.upbound.io/as-conf   True    True     as-conf         54m

NAME                                                               READY   SYNCED   EXTERNAL-NAME          AGE
autoscalinggroup.autoscaling.aws.upbound.io/upbound-example-test   True    True     upbound-example-test   54m
NAME                                        READY   SYNCED   EXTERNAL-NAME   AGE
usergroup.elasticache.aws.upbound.io/test   True    True     test            15m
  • elasticache.aws.upbound.io_users.yaml

I could not create elasticache.User resource because sensitive input arrays are not transferred to Terraform and I created an issue in upjet for this: crossplane/upjet#202
Also, there is a pre-opened issue in the provider-aws repo regarding this: #151

  • medialive.aws.upbound.io_channels.yaml, Manually
NAME                              READY   SYNCED   EXTERNAL-NAME   AGE
role.iam.aws.upbound.io/channel   True    True     channel         7m35s

NAME                                     READY   SYNCED   EXTERNAL-NAME   AGE
input.medialive.aws.upbound.io/channel   True    True     2837575         7m34s

NAME                                                  READY   SYNCED   EXTERNAL-NAME   AGE
inputsecuritygroup.medialive.aws.upbound.io/channel   True    True     6136055         7m34s

NAME                                       READY   SYNCED   EXTERNAL-NAME   AGE
channel.medialive.aws.upbound.io/channel   True    True     7520059         7m35s

NAME                                           READY   SYNCED   EXTERNAL-NAME         AGE
bucket.s3.aws.upbound.io/channel1-fatih-test   True    True     channel1-fatih-test   117s
bucket.s3.aws.upbound.io/channel2              True    True     channel2              7m35s
NAME                                  READY   SYNCED   EXTERNAL-NAME   AGE
role.iam.aws.upbound.io/sample-role   True    True     sample-role     22m

NAME                                                      READY   SYNCED   EXTERNAL-NAME                      AGE
permission.lambda.aws.upbound.io/example-secretrotation   True    True     AllowExecutionFromSecretsManager   22m

NAME                                                    READY   SYNCED   EXTERNAL-NAME            AGE
function.lambda.aws.upbound.io/example-secretrotation   True    True     example-secretrotation   22m

NAME                                                          READY   SYNCED   EXTERNAL-NAME
                                  AGE
secret.secretsmanager.aws.upbound.io/example-secretrotation   True    True     arn:aws:secretsmanager:us-west-1:609897127049:se
cret:example-test-fatih3-F665Wi   22m

NAME                                                   READY   SYNCED   EXTERNAL-NAME
                           AGE
secretrotation.secretsmanager.aws.upbound.io/example   True    True     arn:aws:secretsmanager:us-west-1:609897127049:secret:ex
ample-test-fatih3-F665Wi   22m
  • ssoadmin.aws.upbound.io_permissionsetinlinepolicies.yaml, Manually
NAME                                                        READY   SYNCED   EXTERNAL-NAME
                                                                       AGE
permissionsetinlinepolicy.ssoadmin.aws.upbound.io/example   True    True     arn:aws:sso:::permissionSet/ssoins-72232fef78ce353
a/ps-46d3df602b94d4c7,arn:aws:sso:::instance/ssoins-72232fef78ce353a   4m23s

NAME                                            READY   SYNCED   EXTERNAL-NAME
                                                           AGE
permissionset.ssoadmin.aws.upbound.io/example   True    True     arn:aws:sso:::permissionSet/ssoins-72232fef78ce353a/ps-46d3df6
02b94d4c7,arn:aws:sso:::instance/ssoins-72232fef78ce353a   4m23s

Native state schema version changes

@turkenf turkenf marked this pull request as ready for review May 8, 2023 16:33
@turkenf
Copy link
Collaborator Author

turkenf commented May 8, 2023

/test-examples="examples/appautoscaling/policy.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented May 8, 2023

/test-examples="examples/appmesh/route.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented May 8, 2023

/test-examples="examples/appmesh/virtualrouter.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented May 8, 2023

/test-examples="examples/cognitoidp/user.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented May 8, 2023

/test-examples="examples/scheduler/schedule.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented May 8, 2023

/test-examples="examples/secretsmanager/secretrotation.yaml"

@turkenf turkenf force-pushed the update-tf-provider-4.66.0 branch from 76cfe6d to c47be04 Compare May 9, 2023 12:30
@turkenf
Copy link
Collaborator Author

turkenf commented May 9, 2023

/test-examples="examples/securityhub/account.yaml"

1 similar comment
@turkenf
Copy link
Collaborator Author

turkenf commented May 9, 2023

/test-examples="examples/securityhub/account.yaml"

@turkenf turkenf force-pushed the update-tf-provider-4.66.0 branch from c47be04 to c9f55cc Compare May 10, 2023 07:03
@turkenf
Copy link
Collaborator Author

turkenf commented May 10, 2023

/test-examples="examples/securityhub/account.yaml"

1 similar comment
@turkenf
Copy link
Collaborator Author

turkenf commented May 10, 2023

/test-examples="examples/securityhub/account.yaml"

@turkenf turkenf force-pushed the update-tf-provider-4.66.0 branch 3 times, most recently from 5de8e22 to ff806fe Compare May 10, 2023 14:22
@turkenf
Copy link
Collaborator Author

turkenf commented May 10, 2023

This PR is ready for review.

- aws_autoscaling_policy
- aws_securityhub_account
- aws_secretsmanager_secret_rotation
- aws_ssoadmin_permission_set_inline_policy
@turkenf turkenf force-pushed the update-tf-provider-4.66.0 branch from ff806fe to 971f83a Compare May 10, 2023 14:38
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf LGTM!

@turkenf turkenf merged commit ca8fcac into crossplane-contrib:main May 15, 2023
9 checks passed
@turkenf turkenf deleted the update-tf-provider-4.66.0 branch May 15, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: update terraform provider to a minimum of 4.65.0
2 participants