-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for REDSHIFT SERVERLESS resource #802
Conversation
/test-examples="examples/redshiftserverless/endpointaccess.yaml" |
/test-examples="examples/redshiftserverless/redshiftserverlessnamespace.yaml" |
/test-examples="examples/redshiftserverless/resourcepolicy.yaml" |
/test-examples="examples/redshiftserverless/snapshot.yaml” |
/test-examples="examples/redshiftserverless/snapshot.yaml" |
/test-examples="examples/redshiftserverless/usagelimit.yaml" |
/test-examples="examples/redshiftserverless/workgroup.yaml" |
8051bd8
to
234c6d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @svscheg, I left a few comments and also there is an inconsistency in the group names here. We added the configurations in config/redshift/config.go
but the examples were created under examples/redshiftserverless/...
. If we are going to continue with the redshiftserverless
group we will need to add a new group to the config
file. If we are going to continue with the redshift
group we will need to define the r.ShortGroup
configuration for each resource.
@ulucinar, @sergenyalcin do you have any suggestions on how we should proceed?
Hi @turkenf, |
/test-examples="examples/redshiftserverless/redshiftserverlessnamespace.yaml" |
/test-examples="examples/redshiftserverless/resourcepolicy.yaml" |
e5b8d62
to
f344c24
Compare
/test-examples="examples/redshiftserverless/resourcepolicy.yaml" |
/test-examples="examples/redshiftserverless/redshiftserverlessnamespace.yaml" |
/test-examples="examples/redshiftserverless/workgroup.yaml" |
/test-examples="examples/redshiftserverless/resourcepolicy.yaml" |
@turkenf any ETA for this PR ? |
|
|
/test-examples="examples/redshiftserverless/resourcepolicy.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description of your changes
Add next resources:
aws_redshiftserverless_endpoint_access
aws_redshiftserverless_namespace
aws_redshiftserverless_resource_policy
aws_redshiftserverless_snapshot
aws_redshiftserverless_usage_limit
aws_redshiftserverless_workgroup
Fixes #787
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Manually
Uptest:
aws_redshiftserverless_endpoint_access - https://github.com/upbound/provider-aws/actions/runs/5660522857
aws_redshiftserverless_namespace - https://github.com/upbound/provider-aws/actions/runs/5660780125
aws_redshiftserverless_resource_policy - https://github.com/upbound/provider-aws/actions/runs/5661859010
aws_redshiftserverless_snapshot - https://github.com/upbound/provider-aws/actions/runs/5665469628
aws_redshiftserverless_usage_limit - https://github.com/upbound/provider-aws/actions/runs/5665875186
aws_redshiftserverless_workgroup - https://github.com/upbound/provider-aws/actions/runs/5666118838