Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for REDSHIFT SERVERLESS resource #802

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

svscheg
Copy link
Contributor

@svscheg svscheg commented Jul 25, 2023

Description of your changes

Add next resources:
aws_redshiftserverless_endpoint_access
aws_redshiftserverless_namespace
aws_redshiftserverless_resource_policy
aws_redshiftserverless_snapshot
aws_redshiftserverless_usage_limit
aws_redshiftserverless_workgroup

Fixes #787

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually
Uptest:

aws_redshiftserverless_endpoint_access - https://github.com/upbound/provider-aws/actions/runs/5660522857
aws_redshiftserverless_namespace - https://github.com/upbound/provider-aws/actions/runs/5660780125
aws_redshiftserverless_resource_policy - https://github.com/upbound/provider-aws/actions/runs/5661859010
aws_redshiftserverless_snapshot - https://github.com/upbound/provider-aws/actions/runs/5665469628
aws_redshiftserverless_usage_limit - https://github.com/upbound/provider-aws/actions/runs/5665875186
aws_redshiftserverless_workgroup - https://github.com/upbound/provider-aws/actions/runs/5666118838

@svscheg
Copy link
Contributor Author

svscheg commented Jul 25, 2023

/test-examples="examples/redshiftserverless/endpointaccess.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jul 25, 2023

/test-examples="examples/redshiftserverless/redshiftserverlessnamespace.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jul 25, 2023

/test-examples="examples/redshiftserverless/resourcepolicy.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jul 26, 2023

/test-examples="examples/redshiftserverless/snapshot.yaml”

@svscheg
Copy link
Contributor Author

svscheg commented Jul 26, 2023

/test-examples="examples/redshiftserverless/snapshot.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jul 26, 2023

/test-examples="examples/redshiftserverless/usagelimit.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jul 26, 2023

/test-examples="examples/redshiftserverless/workgroup.yaml"

@svscheg svscheg force-pushed the issue787 branch 2 times, most recently from 8051bd8 to 234c6d0 Compare July 26, 2023 08:53
Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @svscheg, I left a few comments and also there is an inconsistency in the group names here. We added the configurations in config/redshift/config.go but the examples were created under examples/redshiftserverless/.... If we are going to continue with the redshiftserverless group we will need to add a new group to the config file. If we are going to continue with the redshift group we will need to define the r.ShortGroup configuration for each resource.

@ulucinar, @sergenyalcin do you have any suggestions on how we should proceed?

config/redshift/config.go Outdated Show resolved Hide resolved
config/redshift/config.go Outdated Show resolved Hide resolved
examples/redshiftserverless/resourcepolicy.yaml Outdated Show resolved Hide resolved
config/externalname.go Outdated Show resolved Hide resolved
@ulucinar
Copy link
Collaborator

Thanks for this PR @svscheg, I left a few comments and also there is an inconsistency in the group names here. We added the configurations in config/redshift/config.go but the examples were created under examples/redshiftserverless/.... If we are going to continue with the redshiftserverless group we will need to add a new group to the config file. If we are going to continue with the redshift group we will need to define the r.ShortGroup configuration for each resource.

@ulucinar, @sergenyalcin do you have any suggestions on how we should proceed?

Hi @turkenf,
Yes, I agree that the config folder should be config/redshiftserverless rather than config/redshift.

@turkenf
Copy link
Collaborator

turkenf commented Jul 31, 2023

/test-examples="examples/redshiftserverless/redshiftserverlessnamespace.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Jul 31, 2023

/test-examples="examples/redshiftserverless/resourcepolicy.yaml"

@turkenf turkenf force-pushed the issue787 branch 2 times, most recently from e5b8d62 to f344c24 Compare July 31, 2023 21:04
@turkenf
Copy link
Collaborator

turkenf commented Jul 31, 2023

/test-examples="examples/redshiftserverless/resourcepolicy.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 1, 2023

/test-examples="examples/redshiftserverless/redshiftserverlessnamespace.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 1, 2023

/test-examples="examples/redshiftserverless/workgroup.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 1, 2023

/test-examples="examples/redshiftserverless/resourcepolicy.yaml"

@haarchri
Copy link
Member

@turkenf any ETA for this PR ?

@turkenf
Copy link
Collaborator

turkenf commented Sep 21, 2023

examples/redshiftserverless/endpointaccess.yaml: https://github.com/upbound/provider-aws/actions/runs/6261442131

@turkenf
Copy link
Collaborator

turkenf commented Sep 21, 2023

examples/redshiftserverless/resourcepolicy.yaml: https://github.com/upbound/provider-aws/actions/runs/6262141040

@turkenf
Copy link
Collaborator

turkenf commented Sep 21, 2023

/test-examples="examples/redshiftserverless/resourcepolicy.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@turkenf turkenf merged commit eefeab9 into crossplane-contrib:main Sep 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for REDSHIFT SERVERLESS resource
4 participants