Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure and add example for PrincipalAssociation.ram and ResourceShareAccepter.ram #819

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Aug 9, 2023

Description of your changes

In this PR: PrincipalAssociation and ResourceShareAccepter resources have been configured and added examples.

Fixes: #253

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

NAME                                                       READY   SYNCED   EXTERNAL-NAME
                                      AGE
resourceshareaccepter.ram.aws.upbound.io/receiver-accept   True    True     arn:aws:ram:us-west-1:243569053065:resource-share/d
bdb11d5-6d69-43bf-90e8-ce0db2ff9dab   25m

NAME                                            READY   SYNCED   EXTERNAL-NAME
                           AGE
resourceshare.ram.aws.upbound.io/sender-share   True    True     arn:aws:ram:us-west-1:243569053065:resource-share/dbdb11d5-6d6
9-43bf-90e8-ce0db2ff9dab   66m

NAME                                                    READY   SYNCED   EXTERNAL-NAME
                                                AGE
principalassociation.ram.aws.upbound.io/sender-invite   True    True     arn:aws:ram:us-west-1:243569053065:resource-share/dbdb
11d5-6d69-43bf-90e8-ce0db2ff9dab,153891904029   66m

@turkenf
Copy link
Collaborator Author

turkenf commented Aug 9, 2023

/test-examples="examples/ram/resourceshareaccepter.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Aug 9, 2023

/test-examples="examples/ram/resourceshareaccepter.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Aug 9, 2023

/test-examples="examples/ram/principalassociation.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Aug 9, 2023

/test-examples="examples/ram/resourceshareaccepter.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Aug 9, 2023

/test-examples="examples/ram/resourceshareaccepter.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Aug 9, 2023

/test-examples="examples/directconnect/hostedprivatevirtualinterfaceaccepter.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Aug 10, 2023

/test-examples="examples/ram/resourceshareaccepter.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Aug 10, 2023

/test-examples="examples/ram/resourceshareaccepter.yaml"

1 similar comment
@turkenf
Copy link
Collaborator Author

turkenf commented Aug 11, 2023

/test-examples="examples/ram/resourceshareaccepter.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Aug 11, 2023

/test-examples="examples/ram/resourceshareaccepter.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Aug 11, 2023

/test-examples="examples/ram/resourceshareaccepter.yaml"

Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @turkenf, lgtm.

name: sender-invite
spec:
providerConfigRef:
name: peer
Copy link
Collaborator

@ulucinar ulucinar Aug 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @turkenf for your dedication in improving our test automation and going the extra mile to keep our resources uptestable, even when they are cross-account resources.

@turkenf turkenf merged commit 968a3b5 into crossplane-contrib:main Aug 11, 2023
10 checks passed
@turkenf turkenf deleted the issue-253 branch August 11, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving ram (4) resources to v1beta1 version
2 participants