-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure and add example for PrincipalAssociation.ram
and ResourceShareAccepter.ram
#819
Conversation
/test-examples="examples/ram/resourceshareaccepter.yaml" |
/test-examples="examples/ram/resourceshareaccepter.yaml" |
/test-examples="examples/ram/principalassociation.yaml" |
/test-examples="examples/ram/resourceshareaccepter.yaml" |
/test-examples="examples/ram/resourceshareaccepter.yaml" |
/test-examples="examples/directconnect/hostedprivatevirtualinterfaceaccepter.yaml" |
/test-examples="examples/ram/resourceshareaccepter.yaml" |
/test-examples="examples/ram/resourceshareaccepter.yaml" |
1 similar comment
/test-examples="examples/ram/resourceshareaccepter.yaml" |
/test-examples="examples/ram/resourceshareaccepter.yaml" |
/test-examples="examples/ram/resourceshareaccepter.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @turkenf, lgtm.
name: sender-invite | ||
spec: | ||
providerConfigRef: | ||
name: peer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @turkenf for your dedication in improving our test automation and going the extra mile to keep our resources uptestable, even when they are cross-account resources.
Description of your changes
In this PR:
PrincipalAssociation
andResourceShareAccepter
resources have been configured and added examples.Fixes: #253
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
aws_ram_principal_association
: Uptest(https://github.com/upbound/provider-aws/actions/runs/5811127760)aws_ram_resource_share_accepter
: Manually, Uptest(https://github.com/upbound/provider-aws/actions/runs/5831983029)