Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate batch.JobDefinition #899

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Sep 28, 2023

Description of your changes

While merging #896, we did not rebase that PR and the batch.JobDefinition needs to be regenerated against the latest angryjet.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Via uptest here: https://github.com/upbound/provider-aws/actions/runs/6341416822

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@turkenf
Copy link
Collaborator

turkenf commented Sep 28, 2023

/test-examples="examples/batch/jobdefinition.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ulucinar, LGTM.

@ulucinar ulucinar merged commit 7f1bf3b into crossplane-contrib:main Sep 28, 2023
10 checks passed
@ulucinar ulucinar deleted the make-gen branch September 28, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants