Use Terraform Plugin SDK to Reconcile MRs

[ulucinar]

Description of your changes

This PR employs the controller.noForkExternal & controller.noForkAsyncExternal external clients from upjet to reconcile all but the following MRs to reconcile without forking any Terraform CLI or Terraform provider processes:

• SecurityGroupIngressRule.ec2
• SecurityGroupEgressRule.ec2
• Environment.appconfig
• UserPoolClient.cognitoidp
• Domain.simpledb

The above resources are reconciled using the legacy Terraform CLI-based external clients.

Some more details on these clients can be found here.

I have:

• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

The following resources have been validated either by manual tests or uptests.

[ulucinar]

/test-examples="examples/ec2/vpc.yaml"

[ulucinar]

/test-examples="examples/rds/instance.yaml"

[ulucinar]

/test-examples="examples/elasticache/replicationgroup.yaml"

[sergenyalcin]

/test-examples="examples/elasticache/replicationgroup.yaml"

[sergenyalcin]

/test-examples="examples/eks/nodegroup.yaml"

[sergenyalcin]

/test-examples="examples/ec2/serialconsoleaccess.yaml"

[sergenyalcin]

/test-examples="examples/ec2/mainroutetableassociation.yaml"

[sergenyalcin]

/test-examples="examples/ec2/spotinstancerequest.yaml"

[sergenyalcin]

/test-examples="examples/appautoscaling/policy.yaml"

[sergenyalcin]

/test-examples="examples/directconnect/bgppeer.yaml"

[sergenyalcin]

/test-examples="examples/cloudfront/distribution.yaml"

[sergenyalcin]

/test-examples="examples/cloudwatchlogs/metricfilter.yaml"

[sergenyalcin]

/test-examples="examples/glue/datacatalogencryptionsettings.yaml"

[sergenyalcin]

/test-examples="examples/glue/catalogtable.yaml,examples/glue/catalogdatabase.yaml"

[sergenyalcin]

/test-examples="examples/directconnect/bgppeer.yaml"

[sergenyalcin]

/test-examples="examples/kms/grant.yaml"

[sergenyalcin]

/test-examples="examples/glue/catalogtable.yaml,examples/glue/catalogdatabase.yaml"

[sergenyalcin]

/test-examples="examples/mq/broker.yaml"

[sergenyalcin]

/test-examples="examples/glue/catalogtable.yaml,examples/glue/catalogdatabase.yaml"

[sergenyalcin]

/test-examples="examples/networkfirewall/firewall.yaml"

[sergenyalcin]

/test-examples="examples/sns/smspreferences.yaml"

[sergenyalcin]

/test-examples="examples/mq/broker.yaml"

[sergenyalcin]

/test-examples="examples/mq/broker.yaml"

[sergenyalcin]

/test-examples="examples/ec2/flowlog.yaml"

[sergenyalcin]

/test-examples="examples/apigatewayv2/api-http.yaml"

[sergenyalcin]

/test-examples="examples/directconnect/gatewayassociation.yaml"

[sergenyalcin]

/test-examples="examples/ec2/vpcendpointsecuritygroupassociation.yaml"

[sergenyalcin]

/test-examples="examples/ec2/flowlog.yaml"

[sergenyalcin]

/test-examples="examples/s3/bucketlifecycleconfiguration.yaml"

[sergenyalcin]

/test-examples="examples/rds/clusterparametergroup.yaml"

[sergenyalcin]

/test-examples="examples/elbv2/lblistener.yaml"

[sergenyalcin]

/test-examples="examples/timestreamwrite/database.yaml"

[sergenyalcin]

/test-examples="examples/directconnect/bgppeer.yaml"

[sergenyalcin]

/test-examples="examples/s3/bucketlogging.yaml"

[sergenyalcin]

/test-examples="examples/kms/key.yaml"

[sergenyalcin]

/test-examples="examples/s3/bucketpublicaccessblock.yaml"

[sergenyalcin]

/test-examples="examples/iam/role.yaml"

[sergenyalcin]

/test-examples="examples/ec2/vpcendpointsecuritygroupassociation.yaml"

[sergenyalcin]

/test-examples="examples/s3/bucketserversideencryptionconfiguration.yaml"

[sergenyalcin]

/test-examples="examples/ec2/securitygrouprule-self-true.yaml"

[sergenyalcin]

/test-examples="examples/eks/addon.yaml"

[sergenyalcin]

/test-examples="examples/directconnect/gatewayassociation.yaml"

[sergenyalcin]

/test-examples="examples/s3/bucketversioning.yaml"

[sergenyalcin]

/test-examples="examples/rds/subnetgroup.yaml"

[sergenyalcin]

/test-examples="examples/kafka/cluster.yaml"

[sergenyalcin]

/test-examples="examples/directconnect/transitvirtualinterface.yaml"

[ulucinar]

/test-examples="examples/ec2/vpc.yaml"

[ulucinar]

/test-examples="examples/ec2/vpc.yaml"

[ulucinar]

make lint runs successfully on our local development machines. Looks like this is an issue with the runners we are using. Please refer to the issue mentioned in the description of this PR for further details. We tried switching to Ubuntu 20.04 on smaller machines but the linter job is now failing to due high memory consumption.

[sergenyalcin]

Thank you! LGTM!