add support for endpoint configuration of no-fork external client #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
erhancagirici
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
|
/test-examples="examples/iam/role.yaml" |
turkenf
approved these changes
Nov 30, 2023
|
/test-examples="examples/efs/filesystem.yaml" |
|
I left the above comment just to test this issue it is not blocking for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds support for custom endpoint configuration of new architecture external clients. Before this change, custom endpoint configurations were rejected, due to similar implementation with old architecture. However, this limitation is no longer valid for new provider architecture.
Fixes #971
I have:
make reviewable testto ensure this PR is ready for review.