Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: auto-created family provider does not inherit runtimeConfigRef from other providers #665

Closed
1 task done
markphillips100 opened this issue Mar 9, 2024 · 2 comments
Labels
bug Something isn't working needs:triage stale

Comments

@markphillips100
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Affected Resource(s)

provider.pkg.crossplane.io/v1

Resource MRs required to reproduce the bug

apiVersion: pkg.crossplane.io/v1beta1
kind: DeploymentRuntimeConfig
metadata:
  name: provider-azure-family-config
spec:
  deploymentTemplate:
    spec:
      selector: {}
      template:
        metadata:
          labels:
            azure.workload.identity/use: "true"
        spec:
          serviceAccountName: "someservicename"
          containers:
            - name: package-runtime
              args:
                - --enable-external-secret-stores
                - --enable-management-policies
---
apiVersion: pkg.crossplane.io/v1
kind: Provider
metadata:
  name: provider-azure-storage
spec:
  package: xpkg.upbound.io/upbound/provider-azure-storage:0.42.1
  runtimeConfigRef:
    name: provider-azure-family-config

Steps to Reproduce

  1. Create a new DeploymentRuntimeConfig with a name other than "default"
  2. Reference the config in a specific azure child Provider using runtimeConfigRef, e.g. xpkg.upbound.io/upbound/provider-azure-storage.
  3. Wait for the provider to be ready and also the automatically created family provider.
  4. Describe the family provider and check what named runtimeConfig it references.

What happened?

When the family provider is created automatically by creating a child provider, it does not inherit the runtimeConfigRef of the child providers.

Relevant Error Output Snippet

No response

Crossplane Version

1.15.0

Provider Version

0.42.1

Kubernetes Version

1.28.0

Kubernetes Distribution

KinD

Additional Info

Two options are possible to resolve currently:

  1. Create a Provider explicitly for the xpkg.upbound.io/upbound/provider-family-azure and specify the required runtimeConfigRef.
  2. Change the name of the DeploymentRuntimeConfig to "default" so it overrides the existing, and do not specify a runtimeConfigReg in any of the child providers.
@markphillips100 markphillips100 added bug Something isn't working needs:triage labels Mar 9, 2024
@turkenf turkenf removed the community label May 7, 2024
Copy link

github-actions bot commented Aug 6, 2024

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Aug 6, 2024
Copy link

This issue is being closed since there has been no activity for 14 days since marking it as stale. If you still need help, feel free to comment or reopen the issue!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs:triage stale
Projects
None yet
Development

No branches or pull requests

2 participants