feat(meta.pkg): set to v1 #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarchri
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
jeanduplessis
requested changes
Sep 17, 2023
There was a problem hiding this comment.
@haarchri Did you mean to include the build submodule in this commit?
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
haarchri
force-pushed
the
feature/v1
branch
from
b80469c
to
1dead34
Compare
|
@jeanduplessis thanks for review |
jeanduplessis
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
set v1 for meta.pkg.crossplane.io
crossplane want's to remove v1alpha1 versions from meta.pkg.crossplane.io
crossplane/crossplane#4634
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested